Blame corrida-0.96-11-formatsec.patch
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
From c539d49d06fea9c6a9efb4e684a8837b82889f7f Mon Sep 17 00:00:00 2001
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
From: Lubomir Rintel <lkundrak@v3.sk>
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
Date: Wed, 4 Dec 2013 23:16:52 +0100
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
Subject: [PATCH] Fix build with -Werror=format-security
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
Fedora, starting with version 21, will enable this flag in order to limit
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
potentially insecure uses of format strings. It is required for format strings
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
to be constant now.
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
---
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
corrida/console.c | 11 +----------
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
1 file changed, 1 insertion(+), 10 deletions(-)
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
diff --git a/corrida/console.c b/corrida/console.c
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
index 29acc3b..de35b69 100644
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
--- a/corrida/console.c
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
+++ b/corrida/console.c
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
@@ -15,14 +15,5 @@ void corrida_printf( char *message )
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
void console_printf( char *message )
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
{
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
- gboolean corrida_printf_switch = TRUE;
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
- char string[MAX_CORRIDA_STRLEN];
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
-
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
- if (corrida_printf_switch == TRUE) {
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
- strcpy (string, APPLICATION_NAME);
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
- strcat (string, ": ");
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
- strcat (string, message);
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
- strcat (string, "\n");
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
- printf (string);
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
- }
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
+ printf (APPLICATION_NAME ": %s\n", message);
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
}
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
--
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
1.8.4.2
|
|
![](https://seccdn.libravatar.org/avatar/19d6d588001879430ddcedc3493348b9f9f8f576126e024e810c392eff7da7a8?s=16&d=retro) |
53ce4ff |
|