PR#2: Remove /bin/* Provides - rpms/coreutils

rpms / coreutils

#2 Remove /bin/* Provides

Closed 6 years ago by ignatenkobrain. Opened 6 years ago by ignatenkobrain.

Unknown source bin-provides into master

Remove /bin/* Provides

Igor Gnatenko • 6 years ago

0eb4ae7

coreutils.spec

file modified

+4 -32

		`@@ -1,7 +1,7 @@`
		`Summary: A set of basic GNU tools commonly used in shell scripts`
		`Name: coreutils`
		`Version: 8.28`
		`- Release: 2%{?dist}`
		`+ Release: 3%{?dist}`
		`License: GPLv3+`
		`Group: System Environment/Base`
		`Url: https://www.gnu.org/software/coreutils/`
		`@@ -59,37 +59,6 @@`
		`Conflicts: filesystem < 3`
		`# To avoid clobbering installs`
		`Conflicts: coreutils-single`
		`- Provides: /bin/basename`
		`- Provides: /bin/cat`
		`- Provides: /bin/chgrp`
		`- Provides: /bin/chmod`
		`- Provides: /bin/chown`
		`- Provides: /bin/cp`
		`- Provides: /bin/cut`
		`- Provides: /bin/date`
		`- Provides: /bin/dd`
		`- Provides: /bin/df`
		`- Provides: /bin/echo`
		`- Provides: /bin/env`
		`- Provides: /bin/false`
		`- Provides: /bin/ln`
		`- Provides: /bin/ls`
		`- Provides: /bin/mkdir`
		`- Provides: /bin/mknod`
		`- Provides: /bin/mktemp`
		`- Provides: /bin/mv`
		`- Provides: /bin/nice`
		`- Provides: /bin/pwd`
		`- Provides: /bin/readlink`
		`- Provides: /bin/rm`
		`- Provides: /bin/rmdir`
		`- Provides: /bin/sleep`
		`- Provides: /bin/sort`
		`- Provides: /bin/stty`
		`- Provides: /bin/sync`
		`- Provides: /bin/touch`
		`- Provides: /bin/true`
		`- Provides: /bin/uname`

		`BuildRequires: attr`
		`BuildRequires: autoconf`
		`@@ -268,6 +237,9 @@`
		`%license COPYING`

		`%changelog`
		`+ * Tue Nov 14 2017 Igor Gnatenko <ignatenkobrain@fedoraproject.org> - 8.28-3`
		`+ - Remove /bin/* Provides`
		`+`
		`* Tue Nov 07 2017 Igor Gnatenko <ignatenkobrain@fedoraproject.org> - 8.28-2`
		`- Remove very old Provides (mktemp, sh-utils, textwrap, fileutils, stat)`

ignatenkobrain commented 6 years ago

UsrMove happened more than decade ago, time to drop legacy.

Signed-off-by: Igor Gnatenko ignatenkobrain@fedoraproject.org

kdudka commented 6 years ago

You are proposing a backward-incompatible change. There could be 3rd party packages relying on these provides. By applying this change we would prevent them from being installed on Fedora for no real benefit.

UsrMove did not happen more than decade ago. It started in 2012:
https://src.fedoraproject.org/cgit/rpms/filesystem.git/commit/?id=4dd7fd5d

... and Red Hat still supports pre-UsrMove distros.

ignatenkobrain commented 6 years ago

@kdudka then we should add all those provides to coreutils-single because they are supposed to be interchangeable while they are not.

ignatenkobrain commented 6 years ago

... and Red Hat still supports pre-UsrMove distros.

This is pretty much irrelevant in this context. We are doing Fedora here ;)

ignatenkobrain commented 6 years ago

then we should add all those provides to coreutils-single because they are supposed to be interchangeable while they are not.

Or drop Provides: coreutils from coreutils-single, but this definitely has no value.

kdudka commented 6 years ago

I think it works perfectly as it is now:

If you only care about official Fedora packages, you can choose which coreutils* package you want to install.
If you have a 3rd party package that requires /bin/chmod, you can install it on Fedora now.

After applying the proposed change, the second scenario would no longer work.

ignatenkobrain commented 6 years ago

@kdudka but we have no other way to enforce people to NOT use old cruft... And we really need to cleanup that.... Or add provides to coreutils-signle so they are really 1:1 replacement.

kdudka commented 6 years ago

OK, let's merge it for Fedora 29 (after the f28 branch is created).

Pull-Request has been closed by ignatenkobrain

6 years ago