#1 Build doc package with Python 3
Closed 6 years ago by clime. Opened 6 years ago by ishcherb.
rpms/ ishcherb/copr-keygen pyambiguous  into  master

file modified
+7 -11
@@ -8,7 +8,7 @@ 

  

  Name:       copr-keygen

  Version:    1.68

- Release:    1%{?dist}

+ Release:    2%{?dist}

  Summary:    Part of Copr build system. Aux service that generate keys for signd

  

  Group:      Applications/Productivity
@@ -34,9 +34,9 @@ 

  BuildRequires: python3-pytest-cov

  BuildRequires: python3-mock

  

- #for doc package # move to python3 when available in fedora

+ #for doc package

  BuildRequires: sphinx

- BuildRequires: python-sphinxcontrib-httpdomain

+ BuildRequires: python3-sphinxcontrib-httpdomain

  

  Requires:   haveged

  Requires:   gnupg
@@ -68,14 +68,7 @@ 

  Summary:    Code documentation for copr-keygen component of Copr buildsystem

  Obsoletes:  copr-doc < 1.38

  

- BuildRequires: python-devel

- BuildRequires: python-setuptools

- BuildRequires: python-mock

- BuildRequires: python-requests

- BuildRequires: python-six

- BuildRequires: python-flask

- 

- BuildRequires: python-sphinx

+ BuildRequires: python3-sphinx

  

  

  %description doc
@@ -187,6 +180,9 @@ 

  

  

  %changelog

+ * Wed Jan 10 2018 Iryna Shcherbina <ishcherb@redhat.com> - 1.68-2

+ - Build docs with Python 3

+ 

  * Fri Sep 15 2017 clime <clime@redhat.com> 1.68-1

  - Spelling fixes

  

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24121622

The Pull request was updated and the following description is no longer relevant.

This package uses names with ambiguous python- prefix in requirements.

According to Fedora Packaging guidelines for Python, packages must use names with either python2- or python3- prefix in requirements where available.
We are aiming to rename python-* dependencies to python2-*, so we can later switch the python-* namespace to Python 3.

This PR is part of Fedora's Switch to Python 3 effort.

Note that, although this PR was created automatically, we will respond to any comments or issues which you might find with it. We will keep the PR open for review for a week, and if there's no feedback we'll merge it.
The local mock build passed, for Koji scratch build please see simple-koji-ci result.

Note: please do not backport this to f26, f27 branch(es) as some of the modified requirements are not available there

This PR was opened automatically, for source code see here

From a second glance, this is a Python 3 package and uses Python 2 only to build docs, because Python 3 version of python-sphinxcontrib-httpdomain was not available when the package was added. python3-sphinxcontrib-httpdomain exists now, so it is better to just switch to Py 3 for docs.

I am planning to rebase this PR to switch to Py3 for docs package.

rebased onto 3fdd353

6 years ago

Thank you. Good catch!

The change of doc generation to python3 is now in all fedora branches.

Pull-Request has been closed by clime

6 years ago