Blame collectd-lvm-do-not-segfault-when-there-are-no-vgs.patch
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
From 25d7de930baa8a25b232a6276e123ca692c1e710 Mon Sep 17 00:00:00 2001
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
From: =?UTF-8?q?Jan=20Kundr=C3=A1t?= <jan.kundrat@cesnet.cz>
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
Date: Thu, 20 Feb 2014 02:13:20 +0100
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
Subject: [PATCH 1/5] lvm: Do not segfault when there are no VGs
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
---
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
src/lvm.c | 5 +++++
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
1 file changed, 5 insertions(+)
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
diff --git a/src/lvm.c b/src/lvm.c
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
index 6ef3a7b2ae5b..12c621d0569f 100644
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
--- a/src/lvm.c
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
+++ b/src/lvm.c
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
@@ -53,6 +53,11 @@ static int vg_read(vg_t vg, char const *vg_name)
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
lvm_submit (vg_name, "free", lvm_vg_get_free_size(vg));
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
lvs = lvm_vg_list_lvs(vg);
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
+ if (!lvs) {
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
+ /* no VGs are defined, which is not an error per se */
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
+ return (0);
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
+ }
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
+
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
dm_list_iterate_items(lvl, lvs) {
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
lvm_submit(vg_name, lvm_lv_get_name(lvl->lv), lvm_lv_get_size(lvl->lv));
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
}
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
--
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
2.0.0
|
|
![](https://seccdn.libravatar.org/avatar/2a5d5ceaf38d3f35e64d348b25f1f002e64eb2cbad14763b4684a716c4444733?s=16&d=retro) |
182a205 |
|