|
 |
89f728c |
From 98e343ab369e4262511b5fce547728e3e5eefba8 Mon Sep 17 00:00:00 2001
|
|
|
89f728c |
From: Hidehiko Abe <hidehiko@chromium.org>
|
|
|
89f728c |
Date: Fri, 31 Jan 2020 21:27:40 +0000
|
|
|
89f728c |
Subject: [PATCH] Use same condition for field declaration and its use.
|
|
|
89f728c |
|
|
|
89f728c |
cros_supported_configs_ is defined iff OS_CHROMEOS is defined.
|
|
|
89f728c |
However, it is used iff USE_CHROMEOS_MEDIA_ACCELERATION regardless of
|
|
|
89f728c |
OS_CHROMEOS.
|
|
|
89f728c |
This CL aligns the conditions.
|
|
|
89f728c |
|
|
|
89f728c |
BUG=1047719
|
|
|
89f728c |
TEST=Build locally.
|
|
|
89f728c |
|
|
|
89f728c |
Change-Id: I08fe8532c1778ff8c77c7a9d9cdd96ff2a83272f
|
|
|
89f728c |
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030924
|
|
|
89f728c |
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
|
|
|
89f728c |
Reviewed-by: Miguel Casas <mcasas@chromium.org>
|
|
|
89f728c |
Commit-Queue: Miguel Casas <mcasas@chromium.org>
|
|
|
89f728c |
Cr-Commit-Position: refs/heads/master@{#737459}
|
|
|
89f728c |
---
|
|
|
89f728c |
|
|
|
89f728c |
--- a/media/mojo/services/gpu_mojo_media_client.cc
|
|
|
89f728c |
+++ b/media/mojo/services/gpu_mojo_media_client.cc
|
|
|
89f728c |
@@ -157,7 +157,7 @@ GpuMojoMediaClient::GetSupportedVideoDec
|
|
|
89f728c |
supported_config_map[VideoDecoderImplementation::kAlternate] =
|
|
|
89f728c |
*d3d11_supported_configs_;
|
|
|
89f728c |
|
|
|
89f728c |
-#elif BUILDFLAG(USE_CHROMEOS_MEDIA_ACCELERATION)
|
|
|
89f728c |
+#elif defined(OS_CHROMEOS) && BUILDFLAG(USE_CHROMEOS_MEDIA_ACCELERATION)
|
|
|
89f728c |
if (base::FeatureList::IsEnabled(kChromeosVideoDecoder)) {
|
|
|
89f728c |
if (!cros_supported_configs_) {
|
|
|
89f728c |
cros_supported_configs_ =
|
|
|
89f728c |
--- a/media/mojo/services/gpu_mojo_media_client.h
|
|
|
89f728c |
+++ b/media/mojo/services/gpu_mojo_media_client.h
|
|
|
89f728c |
@@ -74,16 +74,13 @@ class GpuMojoMediaClient : public MojoMe
|
|
|
89f728c |
#if defined(OS_CHROMEOS) && BUILDFLAG(USE_CHROMEOS_MEDIA_ACCELERATION)
|
|
|
89f728c |
// Indirectly owned by GpuChildThread.
|
|
|
89f728c |
gpu::GpuMemoryBufferFactory* const gpu_memory_buffer_factory_;
|
|
|
89f728c |
+ base::Optional<SupportedVideoDecoderConfigs> cros_supported_configs_;
|
|
|
89f728c |
#endif // defined(OS_CHROMEOS) && BUILDFLAG(USE_CHROMEOS_MEDIA_ACCELERATION)
|
|
|
89f728c |
CdmProxyFactoryCB cdm_proxy_factory_cb_;
|
|
|
89f728c |
#if defined(OS_WIN)
|
|
|
89f728c |
base::Optional<SupportedVideoDecoderConfigs> d3d11_supported_configs_;
|
|
|
89f728c |
#endif // defined(OS_WIN)
|
|
|
89f728c |
|
|
|
89f728c |
-#if defined(OS_CHROMEOS)
|
|
|
89f728c |
- base::Optional<SupportedVideoDecoderConfigs> cros_supported_configs_;
|
|
|
89f728c |
-#endif // defined(OS_CHROMEOS)
|
|
|
89f728c |
-
|
|
|
89f728c |
DISALLOW_COPY_AND_ASSIGN(GpuMojoMediaClient);
|
|
|
89f728c |
};
|
|
|
89f728c |
|