|
 |
f1db2ee |
../../third_party/blink/renderer/core/editing/commands/delete_selection_command.cc: In member function 'void blink::DeleteSelectionCommand::InitializePositionData(blink::EditingState*)':
|
|
|
f1db2ee |
../../third_party/blink/renderer/core/editing/commands/delete_selection_command.cc:256:59: error: no matching function for call to 'EnclosingNodeOfType(blink::Position&, <unresolved overloaded function type>)'
|
|
|
f1db2ee |
256 | EnclosingNodeOfType(start, &IsA<HTMLTableRowElement>));
|
|
|
f1db2ee |
| ^
|
|
|
f1db2ee |
In file included from ../../third_party/blink/renderer/core/editing/commands/delete_selection_command.cc:34:
|
|
|
f1db2ee |
../../third_party/blink/renderer/core/editing/editing_utilities.h:112:19: note: candidate: 'blink::Node* blink::EnclosingNodeOfType(const Position&, bool (*)(const blink::Node*), blink::EditingBoundaryCrossingRule)'
|
|
|
f1db2ee |
112 | CORE_EXPORT Node* EnclosingNodeOfType(
|
|
|
f1db2ee |
| ^~~~~~~~~~~~~~~~~~~
|
|
|
f1db2ee |
../../third_party/blink/renderer/core/editing/editing_utilities.h:114:12: note: no known conversion for argument 2 from '<unresolved overloaded function type>' to 'bool (*)(const blink::Node*)'
|
|
|
f1db2ee |
114 | bool (*node_is_of_type)(const Node*),
|
|
|
f1db2ee |
| ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
|
f1db2ee |
../../third_party/blink/renderer/core/editing/editing_utilities.h:116:19: note: candidate: 'blink::Node* blink::EnclosingNodeOfType(const PositionInFlatTree&, bool (*)(const blink::Node*), blink::EditingBoundaryCrossingRule)'
|
|
|
f1db2ee |
116 | CORE_EXPORT Node* EnclosingNodeOfType(
|
|
|
f1db2ee |
| ^~~~~~~~~~~~~~~~~~~
|
|
|
f1db2ee |
../../third_party/blink/renderer/core/editing/editing_utilities.h:117:5: note: no known conversion for argument 1 from 'blink::Position' {aka 'blink::PositionTemplate<blink::EditingAlgorithm<blink::NodeTraversal> >'} to 'const PositionInFlatTree&' {aka 'const blink::PositionTemplate<blink::EditingAlgorithm<blink::FlatTreeTraversal> >&'}
|
|
|
f1db2ee |
117 | const PositionInFlatTree&,
|
|
|
f1db2ee |
| ^~~~~~~~~~~~~~~~~~~~~~~~~
|
|
|
f1db2ee |
|
|
|
f1db2ee |
diff --git a/third_party/blink/renderer/core/editing/commands/delete_selection_command.cc b/third_party/blink/renderer/core/editing/commands/delete_selection_command.cc
|
|
|
f1db2ee |
index 6ff6906..dd531ae 100644
|
|
|
f1db2ee |
--- a/third_party/blink/renderer/core/editing/commands/delete_selection_command.cc
|
|
|
f1db2ee |
+++ b/third_party/blink/renderer/core/editing/commands/delete_selection_command.cc
|
|
|
f1db2ee |
@@ -224,6 +224,10 @@ static Position TrailingWhitespacePosition(const Position& position,
|
|
|
f1db2ee |
return Position();
|
|
|
f1db2ee |
}
|
|
|
f1db2ee |
|
|
|
f1db2ee |
+static bool IsAHTMLTableRowElement(const Node* node) {
|
|
|
f1db2ee |
+ return IsA<HTMLTableRowElement>(node);
|
|
|
f1db2ee |
+}
|
|
|
f1db2ee |
+
|
|
|
f1db2ee |
void DeleteSelectionCommand::InitializePositionData(
|
|
|
f1db2ee |
EditingState* editing_state) {
|
|
|
f1db2ee |
DCHECK(!GetDocument().NeedsLayoutTreeUpdate());
|
|
|
f1db2ee |
@@ -253,9 +257,9 @@ void DeleteSelectionCommand::InitializePositionData(
|
|
|
f1db2ee |
end_root_ = RootEditableElementOf(end);
|
|
|
f1db2ee |
|
|
|
f1db2ee |
start_table_row_ = To<HTMLTableRowElement>(
|
|
|
f1db2ee |
- EnclosingNodeOfType(start, &IsA<HTMLTableRowElement>));
|
|
|
f1db2ee |
+ EnclosingNodeOfType(start, &IsAHTMLTableRowElement));
|
|
|
f1db2ee |
end_table_row_ = To<HTMLTableRowElement>(
|
|
|
f1db2ee |
- EnclosingNodeOfType(end, &IsA<HTMLTableRowElement>));
|
|
|
f1db2ee |
+ EnclosingNodeOfType(end, &IsAHTMLTableRowElement));
|
|
|
f1db2ee |
|
|
|
f1db2ee |
// Don't move content out of a table cell.
|
|
|
f1db2ee |
// If the cell is non-editable, enclosingNodeOfType won't return it by
|