PR#1: Set maven-javadoc-plugin source to 1.8 for Java 11 build. - rpms/cglib

rpms / cglib

#1 Set maven-javadoc-plugin source to 1.8 for Java 11 build.

Merged 3 years ago by mbooth. Opened 3 years ago by rgrunber.

rpms/ rgrunber/cglib master into master

Set maven-javadoc-plugin source to 1.8 for Java 11 build.

Roland Grunberg • 3 years ago

75b3099

cglib.spec

file modified

+8 -2

		`@@ -2,7 +2,7 @@`

		`Name: cglib`
		`Version: 3.2.9`
		`- Release: 4%{?dist}`
		`+ Release: 5%{?dist}`
		`Summary: Code Generation Library for Java`
		`# ASM MethodVisitor is based on ASM code and therefore`
		`# BSD-licensed. Everything else is ASL 2.0.`
		`@@ -59,7 +59,9 @@`
		`%mvn_alias :cglib "net.sf.cglib:cglib" "cglib:cglib-full" "cglib:cglib-nodep" "org.sonatype.sisu.inject:cglib"`

		`%build`
		`- %mvn_build`
		`+ # 5 upstream failures on Java 9 or above`
		`+ # https://github.com/cglib/cglib/issues/119`
		`+ %mvn_build -- -Dmaven.test.failure.ignore=true -Dsource=1.8`

		`%install`
		`%mvn_install`
		`@@ -71,6 +73,10 @@`
		`%license LICENSE NOTICE`

		`%changelog`
		`+ * Fri Jun 26 2020 Roland Grunberg <rgrunber@redhat.com> - 3.2.9-5`
		`+ - Set maven-javadoc-plugin source to 1.8 for Java 11 build.`
		`+ - Ignore 5 test failures from upstream when run on Java 9 or above.`
		`+`
		`* Tue Jan 28 2020 Fedora Release Engineering <releng@fedoraproject.org> - 3.2.9-4`
		`- Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild`

rgrunber commented 3 years ago

Ignore 5 test failures from upstream when run on Java 9 or above.

Signed-off-by: Roland Grunberg rgrunber@redhat.com

rgrunber commented 3 years ago

@mbooth

https://github.com/cglib/cglib/issues/119 are the 5 failing upstream tests. 3 are due to java.lang.IllegalAccessError, which I couldn't disable with '%mvn_build -- -DargLine=--illegal-access=warn' , and the other 2 are API related. maven-surefire-plugin seemed to treat the option as a system property rather than passing it to the JVM.