From 75097493586d68ae4d9079651e448adf93a515ee Mon Sep 17 00:00:00 2001
From: Emmanuel Seyman <emmanuel@seyman.fr>
Date: Aug 20 2017 15:10:01 +0000
Subject: tighten macro expansion


---

diff --git a/bugzilla.spec b/bugzilla.spec
index 9be4f3b..f8e8c36 100644
--- a/bugzilla.spec
+++ b/bugzilla.spec
@@ -5,8 +5,7 @@ Summary: Bug tracking system
 URL: https://www.bugzilla.org/
 Name: bugzilla
 Version: 5.0.3
-Group: Applications/Publishing
-Release: 7%{?dist}
+Release: 8%{?dist}
 License: MPLv1.1
 Source0: https://ftp.mozilla.org/pub/mozilla.org/webtools/bugzilla-%{version}.tar.gz
 Source1: bugzilla-httpd-conf
@@ -36,6 +35,7 @@ Requires: perl(JSON::XS) >= 2.01
 Requires: perl(Locale::Language)
 Requires: webserver
 Requires: which
+
 # for building docs
 BuildRequires: latexmk
 BuildRequires: perl-generators
@@ -43,21 +43,20 @@ BuildRequires: perl(File::Copy::Recursive)
 BuildRequires: perl(File::Which)
 BuildRequires: perl(Memoize)
 BuildRequires: python-sphinx
-BuildRequires: texlive-collection-fontsrecommended
 BuildRequires: texlive-collection-latexrecommended
 BuildRequires: texlive-collection-basic
-BuildRequires: texlive-fncychap
-BuildRequires: tex-framed
-BuildRequires: tex-multirow
-BuildRequires: tex-threeparttable
-BuildRequires: tex-titlesec
-BuildRequires: tex-wrapfig
+BuildRequires: tex(fncychap.sty)
+BuildRequires: tex(framed.sty)
+BuildRequires: tex(multirow.sty)
+BuildRequires: tex(threeparttable.sty)
+BuildRequires: tex(titlesec.sty)
+BuildRequires: tex(wrapfig.sty)
 %if 0%{?fedora}
-BuildRequires: texlive-capt-of
-BuildRequires: texlive-eqparbox
-BuildRequires: texlive-needspace
-BuildRequires: texlive-tabulary
-BuildRequires: texlive-upquote
+BuildRequires: tex(capt-of.sty)
+BuildRequires: tex(eqparbox.sty)
+BuildRequires: tex(needspace.sty)
+BuildRequires: tex(tabulary.sty)
+BuildRequires: tex(upquote.sty)
 %endif
 
 %package doc
@@ -76,73 +75,72 @@ BuildRequires: python
 %{?perl_default_filter}
 
 # Remove private modules from the requires stream
-%global __requires_exclude %__requires_exclude|^perl\\(sanitycheck.cgi\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(sanitycheck.cgi\\)$
 
 # Remove all optional modules from the requires stream
 # mod_perl modules
-%global __requires_exclude %__requires_exclude|^perl\\(Apache2::
-%global __requires_exclude %__requires_exclude|^perl\\(ModPerl::
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(Apache2::
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(ModPerl::
 # installation of optional modules
-%global __requires_exclude %__requires_exclude|^perl\\(Config\\)$
-%global __requires_exclude %__requires_exclude|^perl\\(CPAN\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(Config\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(CPAN\\)$
 # authentification modules
-%global __requires_exclude %__requires_exclude|^perl\\(Authen::Radius\\)$
-%global __requires_exclude %__requires_exclude|^perl\\(Net::LDAP
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(Authen::Radius\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(Net::LDAP
 # database modules
-%global __requires_exclude %__requires_exclude|^perl\\(DBD::Oracle\\)$
-%global __requires_exclude %__requires_exclude|^perl\\(DBD::Pg\\)$
-%global __requires_exclude %__requires_exclude|^perl\\(DBI::db\\)$
-%global __requires_exclude %__requires_exclude|^perl\\(DBI::st\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(DBD::Oracle\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(DBD::Pg\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(DBI::db\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(DBI::st\\)$
 # graphical reports and charts
-%global __requires_exclude %__requires_exclude|^perl\\(Chart::Lines\\)$
-%global __requires_exclude %__requires_exclude|^perl\\(GD::Graph\\)$
-%global __requires_exclude %__requires_exclude|^perl\\(GD::Graph\\)$
-%global __requires_exclude %__requires_exclude|^perl\\(Template::Plugin::GD::Image\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(Chart::Lines\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(GD::Graph\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(Template::Plugin::GD::Image\\)$
 # inbound email modules
-%global __requires_exclude %__requires_exclude|^perl\\(Email::MIME::Attachment::Stripper\\)$
-%global __requires_exclude %__requires_exclude|^perl\\(Email::Reply\\)$
-%global __requires_exclude %__requires_exclude|^perl\\(HTML::FormatText::WithLinks\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(Email::MIME::Attachment::Stripper\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(Email::Reply\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(HTML::FormatText::WithLinks\\)$
 # automatic charset detection for text attachments
-%global __requires_exclude %__requires_exclude|^perl\\(Encode
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(Encode
 # sniff MIME type of attachments
-%global __requires_exclude %__requires_exclude|^perl\\(File::MimeInfo::Magic\\)$
-%global __requires_exclude %__requires_exclude|^perl\\(IO::Scalar\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(File::MimeInfo::Magic\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(IO::Scalar\\)$
 # mail queueing
-%global __requires_exclude %__requires_exclude|^perl\\(TheSchwartz\\)$
-%global __requires_exclude %__requires_exclude|^perl\\(Daemon::Generic\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(TheSchwartz\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(Daemon::Generic\\)$
 # smtp security
-%global __requires_exclude %__requires_exclude|^perl\\(Authen::SASL\\)$
-%global __requires_exclude %__requires_exclude|^perl\\(Net::SMTP::SSL\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(Authen::SASL\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(Net::SMTP::SSL\\)$
 # bug moving modules
-%global __requires_exclude %__requires_exclude|^perl\\(MIME::Parser\\)$
-%global __requires_exclude %__requires_exclude|^perl\\(XML::Twig\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(MIME::Parser\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(XML::Twig\\)$
 # update notifications
-%global __requires_exclude %__requires_exclude|^perl\\(LWP::UserAgent\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(LWP::UserAgent\\)$
 # use html in product and group descriptions
-%global __requires_exclude %__requires_exclude|^perl\\(HTML::Parser\\)$
-%global __requires_exclude %__requires_exclude|^perl\\(HTML::Scrubber\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(HTML::Parser\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(HTML::Scrubber\\)$
 # memcached support
-%global __requires_exclude %__requires_exclude|^perl\\(Cache::Memcached\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(Cache::Memcached\\)$
 # documentation
-%global __requires_exclude %__requires_exclude|^perl\\(File::Copy::Recursive\\)$
-%global __requires_exclude %__requires_exclude|^perl\\(File::Which\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(File::Copy::Recursive\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(File::Which\\)$
 # xml-rpc and json-rpc modules
-%global __requires_exclude %__requires_exclude|^perl\\(XMLRPC::
-%global __requires_exclude %__requires_exclude|^perl\\(HTTP::Message\\)$
-%global __requires_exclude %__requires_exclude|^perl\\(Test::Taint\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(XMLRPC::
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(HTTP::Message\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(Test::Taint\\)$
 # extension modules
-%global __requires_exclude %__requires_exclude|^perl\\(Image::Magick\\)$
+%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(Image::Magick\\)$
 
 # and remove the extensions from the provides stream
-%global __provides_exclude %__provides_exclude|^perl\\(Bugzilla::Extension::BmpConvert\\)$
-%global __provides_exclude %__provides_exclude|^perl\\(Bugzilla::Extension::Example\\)$
-%global __provides_exclude %__provides_exclude|^perl\\(Bugzilla::Extension::Example::Auth::Login\\)$
-%global __provides_exclude %__provides_exclude|^perl\\(Bugzilla::Extension::Example::Auth::Verify\\)$
-%global __provides_exclude %__provides_exclude|^perl\\(Bugzilla::Extension::Example::Config\\)$
-%global __provides_exclude %__provides_exclude|^perl\\(Bugzilla::Extension::Example::WebService\\)$
-%global __provides_exclude %__provides_exclude|^perl\\(Bugzilla::Extension::OldBugMove\\)$
-%global __provides_exclude %__provides_exclude|^perl\\(Bugzilla::Extension::OldBugMove::Params\\)$
-%global __provides_exclude %__provides_exclude|^perl\\(Bugzilla::Extension::Voting\\)$
+%global __provides_exclude %{?__provides_exclude:%{__provides_exclude}|}^perl\\(Bugzilla::Extension::BmpConvert\\)$
+%global __provides_exclude %{?__provides_exclude:%{__provides_exclude}|}^perl\\(Bugzilla::Extension::Example\\)$
+%global __provides_exclude %{?__provides_exclude:%{__provides_exclude}|}^perl\\(Bugzilla::Extension::Example::Auth::Login\\)$
+%global __provides_exclude %{?__provides_exclude:%{__provides_exclude}|}^perl\\(Bugzilla::Extension::Example::Auth::Verify\\)$
+%global __provides_exclude %{?__provides_exclude:%{__provides_exclude}|}^perl\\(Bugzilla::Extension::Example::Config\\)$
+%global __provides_exclude %{?__provides_exclude:%{__provides_exclude}|}^perl\\(Bugzilla::Extension::Example::WebService\\)$
+%global __provides_exclude %{?__provides_exclude:%{__provides_exclude}|}^perl\\(Bugzilla::Extension::OldBugMove\\)$
+%global __provides_exclude %{?__provides_exclude:%{__provides_exclude}|}^perl\\(Bugzilla::Extension::OldBugMove::Params\\)$
+%global __provides_exclude %{?__provides_exclude:%{__provides_exclude}|}^perl\\(Bugzilla::Extension::Voting\\)$
 
 %description
 Bugzilla is a popular bug tracking system used by multiple open source projects
@@ -293,6 +291,11 @@ popd > /dev/null)
 %{bzinstallprefix}/bugzilla/contrib/Bugzilla.pm
 
 %changelog
+* Sun Aug 20 2017 Emmanuel Seyman <emmanuel@seyman.fr> - 5.0.3-8
+- Tighten macro expansion (thanks to ppisar)
+- Drop Group tag
+- Use tex(..) BuildRequires where possible
+
 * Mon Aug 07 2017 Emmanuel Seyman <emmanuel@seyman.fr> - 5.0.3-7
 - Add doc-building requirement to fix FTBS
 - Add perl(ExtUtils::MM) to the list of required modules