Blame fde6d79fb8363c4a329a184ef0b107156602b225.patch
|
 |
0b51fee |
From fde6d79fb8363c4a329a184ef0b107156602b225 Mon Sep 17 00:00:00 2001
|
|
|
0b51fee |
From: Wim Taymans <wtaymans@redhat.com>
|
|
|
0b51fee |
Date: Thu, 27 Sep 2018 10:48:45 +0200
|
|
|
0b51fee |
Subject: [PATCH] ModuleState: handle compress/decompress init failure
|
|
|
0b51fee |
|
|
|
0b51fee |
When the unit initcompress or initdecompress function fails,
|
|
|
0b51fee |
m_fileModule is NULL. Return AF_FAIL in that case instead of
|
|
|
0b51fee |
causing NULL pointer dereferences later.
|
|
|
0b51fee |
|
|
|
0b51fee |
Fixes #49
|
|
|
0b51fee |
---
|
|
|
0b51fee |
libaudiofile/modules/ModuleState.cpp | 3 +++
|
|
|
0b51fee |
1 file changed, 3 insertions(+)
|
|
|
0b51fee |
|
|
|
0b51fee |
diff --git a/libaudiofile/modules/ModuleState.cpp b/libaudiofile/modules/ModuleState.cpp
|
|
|
0b51fee |
index 0c29d7a..070fd9b 100644
|
|
|
0b51fee |
--- a/libaudiofile/modules/ModuleState.cpp
|
|
|
0b51fee |
+++ b/libaudiofile/modules/ModuleState.cpp
|
|
|
0b51fee |
@@ -75,6 +75,9 @@ status ModuleState::initFileModule(AFfilehandle file, Track *track)
|
|
|
0b51fee |
m_fileModule = unit->initcompress(track, file->m_fh, file->m_seekok,
|
|
|
0b51fee |
file->m_fileFormat == AF_FILE_RAWDATA, &chunkFrames);
|
|
|
0b51fee |
|
|
|
0b51fee |
+ if (!m_fileModule)
|
|
|
0b51fee |
+ return AF_FAIL;
|
|
|
0b51fee |
+
|
|
|
0b51fee |
if (unit->needsRebuffer)
|
|
|
0b51fee |
{
|
|
|
0b51fee |
assert(unit->nativeSampleFormat == AF_SAMPFMT_TWOSCOMP);
|