Note that this says firewall in comment and fireball in the provide. Not sure which one is good, but I've just moved this as is.

Well, I have been waiting to hear from upstream that we should switch to python3 as primary/only. I don't think they are ready for that change, but we can discuss it.

@toshio can you take a look at this? Should we look at 2.5.0 for python3 primary or keep pushing it out?

So, I think we are ok to Switch to python3 by default in f29(rawhide) and rhel > 7

Can you rebase with that and then I can update to the just released 2.5.0 (or you can in the PR if you want) and we can push the 2.5.0 out with this change.

rebased, let's wait for the CI to give us a build to test?

I've created a skeleton/minimal change for f29:

https://fedoraproject.org/wiki/Changes/Ansible_python3_default

I've tested the scratch build and it seems to work fine here, but could we keep the python2 subpackage around (and just not default)? Some people may have some issue where being able to switch back until it's fixed is nice.

I won't be abale to make that change for couple of days. Please either do that or wait for ~Tuesday. (Feel free to remind me then.)

Thanks. I may get time this weekend, will see. Thanks for your efforts in any case...

ok. I did get some time to think/look at this along with the 2.5.0 update.

Upon further consideration, I think I am ok switching f29+ to python3 only.

• Fedora 29 isn't due out until november, so thats a pretty long runway for Fedora users.
• I suspect upstream will be focusing more on python3, making python2 fixes less urgent, and at least python3 bugs will get a lot of attention.
• There are a number of other ways someone could switch back to python2 ansible currently if they really had to (pip install, virtualenv, ansible hacking/env-setup, custom ansible rpm, etc).
• Also, epel7/rhel7 folks can keep using python2, so at the very least a rhel7/centos7 control host could be used.

The docs don't seem to build with python2 either in f28... will look more at that.

ok. I have pushed my changes based on this, so I am going to close this PR now. ;)

Thanks so much for the work!

The commit I pushed:

• Uses python3 to build docs on all Fedoras (except on f26, which doesn't have pathfix.py, so I just special cased it for now).
• f26/f27/f28 all keep the python3 built, but not default and runs tests on both python2 and python3 versions.
• f29 drops python2 and makes python3 default and runs tests on python3
• Updates to 2.5.0.

I'll work on filing/submitting the f29 change to let people know it's switching to python3 default.

Thanks again!

For reference, this has been done in https://src.fedoraproject.org/rpms/ansible/c/0ad4f4982a675f384437dc3ddf2e2cd075808e62?branch=master

Thanks @kevin!

Notable problems:

rendering: host_group_vars
../bin/testing_formatter.sh
DEPRECATION WARNING: python2 invoked with /usr/bin/python.
    Use /usr/bin/python3 or /usr/bin/python2
    /usr/bin/python will be removed or switched to Python 3 in the future.
    If you cannot make the switch now, please follow instructions at https://fedoraproject.org/wiki/Changes/Avoid_usr_bin_python_in_RPM_Build#Quick_Opt-Out

You need to pathfix also files in test/runner/test.py (those are invoked from testing_formatter.sh)

And:

loading intersphinx inventory from https://docs.python.org/2/objects.inv...
loading intersphinx inventory from ../python2-2.7.13.inv...

You want to use Python 3 intersphinx.

Also, my change did:

+ mkdir tests_bin
+ pushd tests_bin
+ # this is a hack and should be done differently!
+ ln -s `which pytest-3` pytest
+ ln -s %{__python3} python                    # <--- THIS
+ ln -s %{__python3} python2                   # <--- AND THIS
+ export PATH=$PATH:$(pwd)
+ popd

And I don't see any alternative in your commit. Are you absolutely sure your test run on Python 3?

(asciidoc pulls in python2, so in order to check if it builds without python2, you better disable all things that need asciidoc, don't buildrequire it and try a scratchbuild)

I could have messed up somewhere. ;)

Here's a f29 scratch build with the current spec:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25994655

The tests have:

• make PYTHON=/usr/bin/python3 tests-py3
  fatal: not a git repository (or any of the parent directories): .git
  fatal: not a git repository (or any of the parent directories): .git
  fatal: not a git repository (or any of the parent directories): .git
  test/runner/ansible-test units -v --python 3.6
  DEPRECATION WARNING: python2 invoked with /usr/bin/python.
  Use /usr/bin/python3 or /usr/bin/python2
  /usr/bin/python will be removed or switched to Python 3 in the future.
  If you cannot make the switch now, please follow instructions at https://fedoraproject.org/wiki/Changes/Avoid_usr_bin_python_in_RPM_Build#Quick_Opt-Out
  Unit test with Python 3.6
  Run command: pytest --boxed -r a --color no --junit-xml test/results/junit/python3.6-units.xml -v test/units/
  ============================= test session starts ==============================
  platform linux -- Python 3.6.4, pytest-3.4.2, py-1.5.3, pluggy-0.6.0 -- /usr/bin/python3.6
  cachedir: .pytest_cache
  rootdir: /builddir/build/BUILD/python3-ansible-2.5.0-1.fc29, inifile:
  plugins: xdist-1.22.2, mock-1.7.1, forked-0.2
  collecting ... collected 3201 items / 72 skipped
  ...
  ================== 3173 passed, 100 skipped in 570.59 seconds ==================

But if you want to look over the build and file a new PR with improvements, please do. ;)
Note that docs take forever to build, so if you are testing set with_docs to 0 in the appropriate places.

Hint: Every time you see

DEPRECATION WARNING: python2 invoked with /usr/bin/python. Use /usr/bin/python3 or /usr/bin/python2 /usr/bin/python will be removed or switched to Python 3 in the future.

In something that should run on Python 3 only, something is very wrong.

Yet here it is probably because stuff in test/runner has wrong shebangs. Additional pathfix call should fix that.

Preping a PR.