|
 |
8fc58f6 |
From 0c027538f398b3823bedbfbf5f388ad97784a0ec Mon Sep 17 00:00:00 2001
|
|
|
8fc58f6 |
From: Sumit Bose <sbose@redhat.com>
|
|
|
8fc58f6 |
Date: Fri, 16 Nov 2018 13:32:59 +0100
|
|
|
8fc58f6 |
Subject: [PATCH 2/2] adenroll: use _adcli_strv_add_unique for service
|
|
|
8fc58f6 |
principals
|
|
|
8fc58f6 |
|
|
|
8fc58f6 |
Check if service principals is already in the list before adding it.
|
|
|
8fc58f6 |
|
|
|
8fc58f6 |
Related to https://gitlab.freedesktop.org/realmd/adcli/issues/16
|
|
|
8fc58f6 |
---
|
|
|
8fc58f6 |
library/adenroll.c | 31 ++++++++-----------------------
|
|
|
8fc58f6 |
1 file changed, 8 insertions(+), 23 deletions(-)
|
|
|
8fc58f6 |
|
|
|
8fc58f6 |
diff --git a/library/adenroll.c b/library/adenroll.c
|
|
|
8fc58f6 |
index de2242a..e02f403 100644
|
|
|
8fc58f6 |
--- a/library/adenroll.c
|
|
|
8fc58f6 |
+++ b/library/adenroll.c
|
|
|
8fc58f6 |
@@ -313,7 +313,6 @@ add_service_names_to_service_principals (adcli_enroll *enroll)
|
|
|
8fc58f6 |
char *name;
|
|
|
8fc58f6 |
int length = 0;
|
|
|
8fc58f6 |
int i;
|
|
|
8fc58f6 |
- size_t c;
|
|
|
8fc58f6 |
|
|
|
8fc58f6 |
if (enroll->service_principals != NULL) {
|
|
|
8fc58f6 |
length = seq_count (enroll->service_principals);
|
|
|
8fc58f6 |
@@ -322,28 +321,14 @@ add_service_names_to_service_principals (adcli_enroll *enroll)
|
|
|
8fc58f6 |
for (i = 0; enroll->service_names[i] != NULL; i++) {
|
|
|
8fc58f6 |
if (asprintf (&name, "%s/%s", enroll->service_names[i], enroll->computer_name) < 0)
|
|
|
8fc58f6 |
return_unexpected_if_reached ();
|
|
|
8fc58f6 |
- for (c = 0; enroll->service_principals != NULL && enroll->service_principals[c] != NULL; c++) {
|
|
|
8fc58f6 |
- if (strcmp (name, enroll->service_principals[c]) == 0) {
|
|
|
8fc58f6 |
- break;
|
|
|
8fc58f6 |
- }
|
|
|
8fc58f6 |
- }
|
|
|
8fc58f6 |
- if (enroll->service_principals == NULL || enroll->service_principals[c] == NULL) {
|
|
|
8fc58f6 |
- enroll->service_principals = _adcli_strv_add (enroll->service_principals,
|
|
|
8fc58f6 |
- name, &length);
|
|
|
8fc58f6 |
- }
|
|
|
8fc58f6 |
+ enroll->service_principals = _adcli_strv_add_unique (enroll->service_principals,
|
|
|
8fc58f6 |
+ name, &length, false);
|
|
|
8fc58f6 |
|
|
|
8fc58f6 |
if (enroll->host_fqdn) {
|
|
|
8fc58f6 |
if (asprintf (&name, "%s/%s", enroll->service_names[i], enroll->host_fqdn) < 0)
|
|
|
8fc58f6 |
return_unexpected_if_reached ();
|
|
|
8fc58f6 |
- for (c = 0; enroll->service_principals != NULL && enroll->service_principals[c] != NULL; c++) {
|
|
|
8fc58f6 |
- if (strcmp (name, enroll->service_principals[c]) == 0) {
|
|
|
8fc58f6 |
- break;
|
|
|
8fc58f6 |
- }
|
|
|
8fc58f6 |
- }
|
|
|
8fc58f6 |
- if (enroll->service_principals == NULL || enroll->service_principals[c] == NULL) {
|
|
|
8fc58f6 |
- enroll->service_principals = _adcli_strv_add (enroll->service_principals,
|
|
|
8fc58f6 |
- name, &length);
|
|
|
8fc58f6 |
- }
|
|
|
8fc58f6 |
+ enroll->service_principals = _adcli_strv_add_unique (enroll->service_principals,
|
|
|
8fc58f6 |
+ name, &length, false);
|
|
|
8fc58f6 |
}
|
|
|
8fc58f6 |
}
|
|
|
8fc58f6 |
|
|
|
8fc58f6 |
@@ -364,9 +349,9 @@ add_and_remove_service_principals (adcli_enroll *enroll)
|
|
|
8fc58f6 |
list = adcli_enroll_get_service_principals_to_add (enroll);
|
|
|
8fc58f6 |
if (list != NULL) {
|
|
|
8fc58f6 |
for (c = 0; list[c] != NULL; c++) {
|
|
|
8fc58f6 |
- enroll->service_principals = _adcli_strv_add (enroll->service_principals,
|
|
|
8fc58f6 |
- strdup (list[c]),
|
|
|
8fc58f6 |
- &length);
|
|
|
8fc58f6 |
+ enroll->service_principals = _adcli_strv_add_unique (enroll->service_principals,
|
|
|
8fc58f6 |
+ strdup (list[c]),
|
|
|
8fc58f6 |
+ &length, false);
|
|
|
8fc58f6 |
if (enroll->service_principals == NULL) {
|
|
|
8fc58f6 |
return ADCLI_ERR_UNEXPECTED;
|
|
|
8fc58f6 |
}
|
|
|
8fc58f6 |
@@ -1525,7 +1510,7 @@ load_keytab_entry (krb5_context k5,
|
|
|
8fc58f6 |
value = strdup (name);
|
|
|
8fc58f6 |
return_val_if_fail (value != NULL, FALSE);
|
|
|
8fc58f6 |
_adcli_info ("Found service principal in keytab: %s", value);
|
|
|
8fc58f6 |
- enroll->service_principals = _adcli_strv_add (enroll->service_principals, value, NULL);
|
|
|
8fc58f6 |
+ enroll->service_principals = _adcli_strv_add_unique (enroll->service_principals, value, NULL, false);
|
|
|
8fc58f6 |
}
|
|
|
8fc58f6 |
}
|
|
|
8fc58f6 |
|
|
|
8fc58f6 |
--
|
|
|
8fc58f6 |
2.20.1
|
|
|
8fc58f6 |
|