From 8817859d608e9c5f2e60ee72f5be8ee754c9a1a0 Mon Sep 17 00:00:00 2001 From: Al Stone Date: Feb 24 2020 22:41:56 +0000 Subject: Update to 20200214 upstream and refresh patches Signed-off-by: Al Stone --- diff --git a/.gitignore b/.gitignore index d204c27..c9f2b27 100644 --- a/.gitignore +++ b/.gitignore @@ -125,3 +125,5 @@ series /acpitests-unix-20191213.tar.gz /acpica-unix2-20200110.tar.gz /acpitests-unix-20200110.tar.gz +/acpica-unix2-20200214.tar.gz +/acpitests-unix-20200214.tar.gz diff --git a/acpica-tools.spec b/acpica-tools.spec index dd06101..bcac358 100644 --- a/acpica-tools.spec +++ b/acpica-tools.spec @@ -1,5 +1,5 @@ Name: acpica-tools -Version: 20200110 +Version: 20200214 Release: 1%{?dist} Summary: ACPICA tools for the development and debug of ACPI tables @@ -239,6 +239,9 @@ fi %changelog +* Mon Feb 24 2020 Al Stone - 20200214-1 +- Update to 20200214 source tree, including patch refreshes + * Mon Feb 24 2020 Al Stone - 20200110-1 - Update to 20200110 source tree, including patch refreshes diff --git a/badcode.asl.result b/badcode.asl.result index e4f174c..7f3e923 100644 --- a/badcode.asl.result +++ b/badcode.asl.result @@ -68,7 +68,7 @@ badcode.asl 97: Method (MTH2) Remark 2119 - ^ Control Method marked Serialized (Due to use of Switch operator) badcode.asl 97: Method (MTH2) -Warning 3115 - ^ Not all control paths return a value (MTH2) +Warning 3115 - ^ Not all control paths return a value (\MTH2) badcode.asl 101: Switch (ToInteger (INT1)) Error 6078 - ^ No Case statements under Switch @@ -77,13 +77,13 @@ badcode.asl 120: Store (MTH2 (), Local0) Warning 3144 - ^ Method Local is set but never used (Local0) badcode.asl 120: Store (MTH2 (), Local0) -Warning 3122 - ^ Called method may not always return a value +Warning 3122 - ^ Called method may not always return a value (\MTH2) badcode.asl 126: Method (MTH5) {Store (MTH4(), Local0)} Warning 3144 - Method Local is set but never used ^ (Local0) badcode.asl 126: Method (MTH5) {Store (MTH4(), Local0)} -Error 6080 - Called method returns no value ^ +Error 6080 - Called method returns no value ^ (\MTH4) badcode.asl 132: Name (_HID, "*PNP0C0A") // Illegal leading asterisk Error 6061 - Invalid leading asterisk ^ (*PNP0C0A) @@ -256,11 +256,11 @@ Warning 3144 - ^ Method Local is set but never used Intel ACPI Component Architecture ASL+ Optimizing Compiler/Disassembler version VVVVVVVV -Copyright (c) 2000 - 2019 Intel Corporation +Copyright (c) 2000 - 2020 Intel Corporation Ignoring all errors, forcing AML file generation -ASL Input: badcode.asl - 11587 bytes 81 keywords 408 source lines +ASL Input: badcode.asl - 11588 bytes 81 keywords 408 source lines AML Output: badcode.aml - 1195 bytes 20 opcodes 61 named objects Compilation successful. 45 Errors, 29 Warnings, 11 Remarks, 16 Optimizations, 1 Constants Folded diff --git a/big-endian.patch b/big-endian.patch index bb12ed6..8d89a5b 100644 --- a/big-endian.patch +++ b/big-endian.patch @@ -8,10 +8,10 @@ To date, this has been critical for the s390x architecture only. Signed-off-by: Al Stone -Index: acpica-unix-20191018/source/compiler/aslcodegen.c +Index: acpica-unix-20200214/source/compiler/aslcodegen.c =================================================================== ---- acpica-unix-20191018.orig/source/compiler/aslcodegen.c -+++ acpica-unix-20191018/source/compiler/aslcodegen.c +--- acpica-unix-20200214.orig/source/compiler/aslcodegen.c ++++ acpica-unix-20200214/source/compiler/aslcodegen.c @@ -237,16 +237,12 @@ CgWriteAmlOpcode ( ACPI_PARSE_OBJECT *Op) { @@ -253,10 +253,10 @@ Index: acpica-unix-20191018/source/compiler/aslcodegen.c case AML_RAW_DATA_BUFFER: -Index: acpica-unix-20191018/source/compiler/aslopcodes.c +Index: acpica-unix-20200214/source/compiler/aslopcodes.c =================================================================== ---- acpica-unix-20191018.orig/source/compiler/aslopcodes.c -+++ acpica-unix-20191018/source/compiler/aslopcodes.c +--- acpica-unix-20200214.orig/source/compiler/aslopcodes.c ++++ acpica-unix-20200214/source/compiler/aslopcodes.c @@ -485,6 +485,7 @@ OpcDoUnicode ( UINT32 i; UINT8 *AsciiString; @@ -275,10 +275,10 @@ Index: acpica-unix-20191018/source/compiler/aslopcodes.c } /* -Index: acpica-unix-20191018/source/compiler/aslrestype1.c +Index: acpica-unix-20200214/source/compiler/aslrestype1.c =================================================================== ---- acpica-unix-20191018.orig/source/compiler/aslrestype1.c -+++ acpica-unix-20191018/source/compiler/aslrestype1.c +--- acpica-unix-20200214.orig/source/compiler/aslrestype1.c ++++ acpica-unix-20200214/source/compiler/aslrestype1.c @@ -142,6 +142,11 @@ RsDoMemory24Descriptor ( ACPI_PARSE_OBJECT *LengthOp = NULL; ASL_RESOURCE_NODE *Rnode; @@ -475,10 +475,10 @@ Index: acpica-unix-20191018/source/compiler/aslrestype1.c RsCreateDwordField (InitializerOp, ACPI_RESTAG_LENGTH, CurrentByteOffset + ASL_RESDESC_OFFSET (FixedMemory32.AddressLength)); break; -Index: acpica-unix-20191018/source/compiler/aslrestype1i.c +Index: acpica-unix-20200214/source/compiler/aslrestype1i.c =================================================================== ---- acpica-unix-20191018.orig/source/compiler/aslrestype1i.c -+++ acpica-unix-20191018/source/compiler/aslrestype1i.c +--- acpica-unix-20200214.orig/source/compiler/aslrestype1i.c ++++ acpica-unix-20200214/source/compiler/aslrestype1i.c @@ -198,6 +198,8 @@ RsDoFixedDmaDescriptor ( ACPI_PARSE_OBJECT *InitializerOp; ASL_RESOURCE_NODE *Rnode; @@ -615,10 +615,10 @@ Index: acpica-unix-20191018/source/compiler/aslrestype1i.c + ACPI_MOVE_16_TO_16(&Descriptor->Irq.IrqMask, &IrqMask); return (Rnode); } -Index: acpica-unix-20191018/source/compiler/aslrestype2.c +Index: acpica-unix-20200214/source/compiler/aslrestype2.c =================================================================== ---- acpica-unix-20191018.orig/source/compiler/aslrestype2.c -+++ acpica-unix-20191018/source/compiler/aslrestype2.c +--- acpica-unix-20200214.orig/source/compiler/aslrestype2.c ++++ acpica-unix-20200214/source/compiler/aslrestype2.c @@ -76,6 +76,7 @@ RsDoGeneralRegisterDescriptor ( ACPI_PARSE_OBJECT *InitializerOp; ASL_RESOURCE_NODE *Rnode; @@ -759,10 +759,10 @@ Index: acpica-unix-20191018/source/compiler/aslrestype2.c /* Point to end-of-descriptor for vendor data */ -Index: acpica-unix-20191018/source/compiler/aslrestype2d.c +Index: acpica-unix-20200214/source/compiler/aslrestype2d.c =================================================================== ---- acpica-unix-20191018.orig/source/compiler/aslrestype2d.c -+++ acpica-unix-20191018/source/compiler/aslrestype2d.c +--- acpica-unix-20200214.orig/source/compiler/aslrestype2d.c ++++ acpica-unix-20200214/source/compiler/aslrestype2d.c @@ -79,7 +79,13 @@ RsDoDwordIoDescriptor ( ACPI_PARSE_OBJECT *GranOp = NULL; ASL_RESOURCE_NODE *Rnode; @@ -1118,10 +1118,10 @@ Index: acpica-unix-20191018/source/compiler/aslrestype2d.c Rnode->BufferLength = sizeof (AML_RESOURCE_ADDRESS32) + OptionIndex + StringLength; return (Rnode); -Index: acpica-unix-20191018/source/compiler/aslrestype2e.c +Index: acpica-unix-20200214/source/compiler/aslrestype2e.c =================================================================== ---- acpica-unix-20191018.orig/source/compiler/aslrestype2e.c -+++ acpica-unix-20191018/source/compiler/aslrestype2e.c +--- acpica-unix-20200214.orig/source/compiler/aslrestype2e.c ++++ acpica-unix-20200214/source/compiler/aslrestype2e.c @@ -78,6 +78,13 @@ RsDoExtendedIoDescriptor ( ACPI_PARSE_OBJECT *GranOp = NULL; ASL_RESOURCE_NODE *Rnode; @@ -1227,10 +1227,10 @@ Index: acpica-unix-20191018/source/compiler/aslrestype2e.c Rnode->BufferLength = sizeof (AML_RESOURCE_EXTENDED_ADDRESS64) + StringLength; return (Rnode); -Index: acpica-unix-20191018/source/compiler/aslrestype2q.c +Index: acpica-unix-20200214/source/compiler/aslrestype2q.c =================================================================== ---- acpica-unix-20191018.orig/source/compiler/aslrestype2q.c -+++ acpica-unix-20191018/source/compiler/aslrestype2q.c +--- acpica-unix-20200214.orig/source/compiler/aslrestype2q.c ++++ acpica-unix-20200214/source/compiler/aslrestype2q.c @@ -80,7 +80,13 @@ RsDoQwordIoDescriptor ( ASL_RESOURCE_NODE *Rnode; UINT8 *OptionalFields; @@ -1569,10 +1569,10 @@ Index: acpica-unix-20191018/source/compiler/aslrestype2q.c Rnode->BufferLength = sizeof (AML_RESOURCE_ADDRESS64) + OptionIndex + StringLength; return (Rnode); -Index: acpica-unix-20191018/source/compiler/aslrestype2s.c +Index: acpica-unix-20200214/source/compiler/aslrestype2s.c =================================================================== ---- acpica-unix-20191018.orig/source/compiler/aslrestype2s.c -+++ acpica-unix-20191018/source/compiler/aslrestype2s.c +--- acpica-unix-20200214.orig/source/compiler/aslrestype2s.c ++++ acpica-unix-20200214/source/compiler/aslrestype2s.c @@ -340,9 +340,14 @@ RsDoGpioIntDescriptor ( UINT16 VendorLength; UINT16 InterruptLength; @@ -2038,10 +2038,10 @@ Index: acpica-unix-20191018/source/compiler/aslrestype2s.c MpSaveSerialInfo (Info->MappingOp, Descriptor, ResourceSource); return (Rnode); } -Index: acpica-unix-20191018/source/compiler/aslrestype2w.c +Index: acpica-unix-20200214/source/compiler/aslrestype2w.c =================================================================== ---- acpica-unix-20191018.orig/source/compiler/aslrestype2w.c -+++ acpica-unix-20191018/source/compiler/aslrestype2w.c +--- acpica-unix-20200214.orig/source/compiler/aslrestype2w.c ++++ acpica-unix-20200214/source/compiler/aslrestype2w.c @@ -81,6 +81,12 @@ RsDoWordIoDescriptor ( UINT8 *OptionalFields; UINT16 StringLength = 0; @@ -2385,10 +2385,10 @@ Index: acpica-unix-20191018/source/compiler/aslrestype2w.c Rnode->BufferLength = sizeof (AML_RESOURCE_ADDRESS16) + OptionIndex + StringLength; return (Rnode); -Index: acpica-unix-20191018/source/include/acmacros.h +Index: acpica-unix-20200214/source/include/acmacros.h =================================================================== ---- acpica-unix-20191018.orig/source/include/acmacros.h -+++ acpica-unix-20191018/source/include/acmacros.h +--- acpica-unix-20200214.orig/source/include/acmacros.h ++++ acpica-unix-20200214/source/include/acmacros.h @@ -98,9 +98,12 @@ ((UINT8 *)(void *)(d))[6] = ((UINT8 *)(void *)(s))[1];\ ((UINT8 *)(void *)(d))[7] = ((UINT8 *)(void *)(s))[0];} @@ -2467,10 +2467,10 @@ Index: acpica-unix-20191018/source/include/acmacros.h #define ACPI_MOVE_32_TO_16(d, s) ACPI_MOVE_16_TO_16(d, s) /* Truncate to 16 */ -Index: acpica-unix-20191018/source/include/platform/aclinux.h +Index: acpica-unix-20200214/source/include/platform/aclinux.h =================================================================== ---- acpica-unix-20191018.orig/source/include/platform/aclinux.h -+++ acpica-unix-20191018/source/include/platform/aclinux.h +--- acpica-unix-20200214.orig/source/include/platform/aclinux.h ++++ acpica-unix-20200214/source/include/platform/aclinux.h @@ -198,6 +198,7 @@ #ifdef ACPI_USE_STANDARD_HEADERS @@ -2490,11 +2490,11 @@ Index: acpica-unix-20191018/source/include/platform/aclinux.h #endif /* __KERNEL__ */ #endif /* __ACLINUX_H__ */ -Index: acpica-unix-20191018/source/compiler/aslanalyze.c +Index: acpica-unix-20200214/source/compiler/aslanalyze.c =================================================================== ---- acpica-unix-20191018.orig/source/compiler/aslanalyze.c -+++ acpica-unix-20191018/source/compiler/aslanalyze.c -@@ -461,7 +461,7 @@ ApCheckForGpeNameConflict ( +--- acpica-unix-20200214.orig/source/compiler/aslanalyze.c ++++ acpica-unix-20200214/source/compiler/aslanalyze.c +@@ -469,7 +469,7 @@ ApCheckForGpeNameConflict ( /* Need a null-terminated string version of NameSeg */ @@ -2503,7 +2503,7 @@ Index: acpica-unix-20191018/source/compiler/aslanalyze.c Name[ACPI_NAMESEG_SIZE] = 0; /* -@@ -488,7 +488,7 @@ ApCheckForGpeNameConflict ( +@@ -496,7 +496,7 @@ ApCheckForGpeNameConflict ( * We are now sure we have an _Lxx or _Exx. * Create the target name that would cause collision (Flip E/L) */ @@ -2512,10 +2512,10 @@ Index: acpica-unix-20191018/source/compiler/aslanalyze.c /* Inject opposite letter ("L" versus "E") */ -Index: acpica-unix-20191018/source/compiler/asllookup.c +Index: acpica-unix-20200214/source/compiler/asllookup.c =================================================================== ---- acpica-unix-20191018.orig/source/compiler/asllookup.c -+++ acpica-unix-20191018/source/compiler/asllookup.c +--- acpica-unix-20200214.orig/source/compiler/asllookup.c ++++ acpica-unix-20200214/source/compiler/asllookup.c @@ -119,6 +119,7 @@ LkIsObjectUsed ( { ACPI_NAMESPACE_NODE *Node = ACPI_CAST_PTR (ACPI_NAMESPACE_NODE, ObjHandle); @@ -2546,10 +2546,10 @@ Index: acpica-unix-20191018/source/compiler/asllookup.c AslError (ASL_REMARK, ASL_MSG_NOT_REFERENCED, LkGetNameOp (Node->Op), AslGbl_MsgBuffer); return (AE_OK); -Index: acpica-unix-20191018/source/compiler/aslmain.c +Index: acpica-unix-20200214/source/compiler/aslmain.c =================================================================== ---- acpica-unix-20191018.orig/source/compiler/aslmain.c -+++ acpica-unix-20191018/source/compiler/aslmain.c +--- acpica-unix-20200214.orig/source/compiler/aslmain.c ++++ acpica-unix-20200214/source/compiler/aslmain.c @@ -101,18 +101,6 @@ main ( signal (SIGINT, AslSignalHandler); @@ -2569,10 +2569,10 @@ Index: acpica-unix-20191018/source/compiler/aslmain.c AcpiOsInitialize (); ACPI_DEBUG_INITIALIZE (); /* For debug version only */ -Index: acpica-unix-20191018/source/common/acfileio.c +Index: acpica-unix-20200214/source/common/acfileio.c =================================================================== ---- acpica-unix-20191018.orig/source/common/acfileio.c -+++ acpica-unix-20191018/source/common/acfileio.c +--- acpica-unix-20200214.orig/source/common/acfileio.c ++++ acpica-unix-20200214/source/common/acfileio.c @@ -280,6 +280,7 @@ AcGetOneTableFromFile ( ACPI_TABLE_HEADER *Table; INT32 Count; @@ -2639,10 +2639,10 @@ Index: acpica-unix-20191018/source/common/acfileio.c (UINT32) (FileSize - TableOffset)); return (AE_BAD_HEADER); } -Index: acpica-unix-20191018/source/common/dmtable.c +Index: acpica-unix-20200214/source/common/dmtable.c =================================================================== ---- acpica-unix-20191018.orig/source/common/dmtable.c -+++ acpica-unix-20191018/source/common/dmtable.c +--- acpica-unix-20200214.orig/source/common/dmtable.c ++++ acpica-unix-20200214/source/common/dmtable.c @@ -551,7 +551,7 @@ AcpiDmDumpDataTable ( */ if (ACPI_COMPARE_NAMESEG (Table->Signature, ACPI_SIG_FACS)) @@ -2741,10 +2741,10 @@ Index: acpica-unix-20191018/source/common/dmtable.c AcpiDmNfitSubnames[Temp16]); break; -Index: acpica-unix-20191018/source/common/dmtables.c +Index: acpica-unix-20200214/source/common/dmtables.c =================================================================== ---- acpica-unix-20191018.orig/source/common/dmtables.c -+++ acpica-unix-20191018/source/common/dmtables.c +--- acpica-unix-20200214.orig/source/common/dmtables.c ++++ acpica-unix-20200214/source/common/dmtables.c @@ -142,7 +142,9 @@ AdCreateTableHeader ( ACPI_TABLE_HEADER *Table) { @@ -2808,12 +2808,12 @@ Index: acpica-unix-20191018/source/common/dmtables.c + ACPI_MOVE_32_TO_32(&AmlLength, &Table->Length); + AmlLength -= sizeof (ACPI_TABLE_HEADER); AmlStart = ((UINT8 *) Table + sizeof (ACPI_TABLE_HEADER)); - ASL_CV_INIT_FILETREE(Table, AmlStart, AmlLength); -Index: acpica-unix-20191018/source/compiler/dtfield.c + AcpiUtSetIntegerWidth (Table->Revision); +Index: acpica-unix-20200214/source/compiler/dtfield.c =================================================================== ---- acpica-unix-20191018.orig/source/compiler/dtfield.c -+++ acpica-unix-20191018/source/compiler/dtfield.c +--- acpica-unix-20200214.orig/source/compiler/dtfield.c ++++ acpica-unix-20200214/source/compiler/dtfield.c @@ -361,7 +361,27 @@ DtCompileInteger ( DtError (ASL_ERROR, ASL_MSG_INTEGER_SIZE, Field, AslGbl_MsgBuffer); } @@ -2843,10 +2843,10 @@ Index: acpica-unix-20191018/source/compiler/dtfield.c return; } -Index: acpica-unix-20191018/source/compiler/dtsubtable.c +Index: acpica-unix-20200214/source/compiler/dtsubtable.c =================================================================== ---- acpica-unix-20191018.orig/source/compiler/dtsubtable.c -+++ acpica-unix-20191018/source/compiler/dtsubtable.c +--- acpica-unix-20200214.orig/source/compiler/dtsubtable.c ++++ acpica-unix-20200214/source/compiler/dtsubtable.c @@ -378,6 +378,21 @@ DtSetSubtableLength ( return; } @@ -2871,10 +2871,10 @@ Index: acpica-unix-20191018/source/compiler/dtsubtable.c + Subtable->SizeOfLengthField); + } } -Index: acpica-unix-20191018/source/compiler/dttable1.c +Index: acpica-unix-20200214/source/compiler/dttable1.c =================================================================== ---- acpica-unix-20191018.orig/source/compiler/dttable1.c -+++ acpica-unix-20191018/source/compiler/dttable1.c +--- acpica-unix-20200214.orig/source/compiler/dttable1.c ++++ acpica-unix-20200214/source/compiler/dttable1.c @@ -281,6 +281,8 @@ DtCompileCsrt ( DT_FIELD **PFieldList = (DT_FIELD **) List; UINT32 DescriptorCount; @@ -3246,10 +3246,10 @@ Index: acpica-unix-20191018/source/compiler/dttable1.c return (AE_OK); } -Index: acpica-unix-20191018/source/compiler/dttable2.c +Index: acpica-unix-20200214/source/compiler/dttable2.c =================================================================== ---- acpica-unix-20191018.orig/source/compiler/dttable2.c -+++ acpica-unix-20191018/source/compiler/dttable2.c +--- acpica-unix-20200214.orig/source/compiler/dttable2.c ++++ acpica-unix-20200214/source/compiler/dttable2.c @@ -345,7 +345,7 @@ DtCompileMpst ( DtPushSubtable (Subtable); @@ -3360,7 +3360,7 @@ Index: acpica-unix-20191018/source/compiler/dttable2.c LocalityBuffer = UtLocalCalloc (Localities); LocalityListLength = 0; -@@ -1740,6 +1746,7 @@ DtCompileTcpa ( +@@ -1741,6 +1747,7 @@ DtCompileTcpa ( ACPI_TABLE_TCPA_HDR *TcpaHeader; DT_SUBTABLE *ParentTable; ACPI_STATUS Status; @@ -3368,7 +3368,7 @@ Index: acpica-unix-20191018/source/compiler/dttable2.c /* Compile the main table */ -@@ -1760,7 +1767,8 @@ DtCompileTcpa ( +@@ -1761,7 +1768,8 @@ DtCompileTcpa ( */ TcpaHeader = ACPI_CAST_PTR (ACPI_TABLE_TCPA_HDR, ParentTable->Buffer); @@ -3378,7 +3378,7 @@ Index: acpica-unix-20191018/source/compiler/dttable2.c { case ACPI_TCPA_CLIENT_TABLE: -@@ -1808,6 +1816,7 @@ DtCompileTpm2Rev3 ( +@@ -1809,6 +1817,7 @@ DtCompileTpm2Rev3 ( ACPI_TABLE_TPM23 *Tpm23Header; DT_SUBTABLE *ParentTable; ACPI_STATUS Status = AE_OK; @@ -3386,7 +3386,7 @@ Index: acpica-unix-20191018/source/compiler/dttable2.c Status = DtCompileTable (PFieldList, AcpiDmTableInfoTpm23, -@@ -1819,7 +1828,8 @@ DtCompileTpm2Rev3 ( +@@ -1820,7 +1829,8 @@ DtCompileTpm2Rev3 ( /* Subtable type depends on the StartMethod */ @@ -3396,7 +3396,7 @@ Index: acpica-unix-20191018/source/compiler/dttable2.c { case ACPI_TPM23_ACPI_START_METHOD: -@@ -1866,6 +1876,7 @@ DtCompileTpm2 ( +@@ -1867,6 +1877,7 @@ DtCompileTpm2 ( DT_SUBTABLE *ParentTable; ACPI_STATUS Status = AE_OK; ACPI_TABLE_HEADER *Header; @@ -3404,7 +3404,7 @@ Index: acpica-unix-20191018/source/compiler/dttable2.c ParentTable = DtPeekSubtable (); -@@ -1909,7 +1920,8 @@ DtCompileTpm2 ( +@@ -1910,7 +1921,8 @@ DtCompileTpm2 ( /* Subtable type depends on the StartMethod */ @@ -3414,7 +3414,7 @@ Index: acpica-unix-20191018/source/compiler/dttable2.c { case ACPI_TPM2_COMMAND_BUFFER_WITH_ARM_SMC: -@@ -2125,6 +2137,9 @@ DtCompileWpbt ( +@@ -2126,6 +2138,9 @@ DtCompileWpbt ( ACPI_TABLE_WPBT *Table; ACPI_STATUS Status; UINT16 Length; @@ -3424,7 +3424,7 @@ Index: acpica-unix-20191018/source/compiler/dttable2.c /* Compile the main table */ -@@ -2152,7 +2167,16 @@ DtCompileWpbt ( +@@ -2153,7 +2168,16 @@ DtCompileWpbt ( Length = (UINT16) Subtable->TotalLength; Table = ACPI_CAST_PTR (ACPI_TABLE_WPBT, ParentTable->Buffer); @@ -3442,10 +3442,10 @@ Index: acpica-unix-20191018/source/compiler/dttable2.c ParentTable = DtPeekSubtable (); DtInsertSubtable (ParentTable, Subtable); -Index: acpica-unix-20191018/source/components/disassembler/dmbuffer.c +Index: acpica-unix-20200214/source/components/disassembler/dmbuffer.c =================================================================== ---- acpica-unix-20191018.orig/source/components/disassembler/dmbuffer.c -+++ acpica-unix-20191018/source/components/disassembler/dmbuffer.c +--- acpica-unix-20200214.orig/source/components/disassembler/dmbuffer.c ++++ acpica-unix-20200214/source/components/disassembler/dmbuffer.c @@ -204,7 +204,7 @@ AcpiDmByteList ( @@ -3521,10 +3521,10 @@ Index: acpica-unix-20191018/source/components/disassembler/dmbuffer.c NextOp = AcpiPsGetDepthNext (NULL, Op); if (!NextOp) -Index: acpica-unix-20191018/source/components/disassembler/dmopcode.c +Index: acpica-unix-20200214/source/components/disassembler/dmopcode.c =================================================================== ---- acpica-unix-20191018.orig/source/components/disassembler/dmopcode.c -+++ acpica-unix-20191018/source/components/disassembler/dmopcode.c +--- acpica-unix-20200214.orig/source/components/disassembler/dmopcode.c ++++ acpica-unix-20200214/source/components/disassembler/dmopcode.c @@ -244,6 +244,7 @@ AcpiDmPredefinedDescription ( char *NameString; int LastCharIsDigit; @@ -3595,10 +3595,10 @@ Index: acpica-unix-20191018/source/components/disassembler/dmopcode.c Info->Level += 1; Info->MappingOp = Op; -Index: acpica-unix-20191018/source/components/disassembler/dmresrcl.c +Index: acpica-unix-20200214/source/components/disassembler/dmresrcl.c =================================================================== ---- acpica-unix-20191018.orig/source/components/disassembler/dmresrcl.c -+++ acpica-unix-20191018/source/components/disassembler/dmresrcl.c +--- acpica-unix-20200214.orig/source/components/disassembler/dmresrcl.c ++++ acpica-unix-20200214/source/components/disassembler/dmresrcl.c @@ -141,7 +141,8 @@ AcpiDmMemoryFields ( UINT32 Level) { @@ -3747,10 +3747,10 @@ Index: acpica-unix-20191018/source/components/disassembler/dmresrcl.c } AcpiDmIndent (Level); -Index: acpica-unix-20191018/source/components/disassembler/dmresrcl2.c +Index: acpica-unix-20200214/source/components/disassembler/dmresrcl2.c =================================================================== ---- acpica-unix-20191018.orig/source/components/disassembler/dmresrcl2.c -+++ acpica-unix-20191018/source/components/disassembler/dmresrcl2.c +--- acpica-unix-20200214.orig/source/components/disassembler/dmresrcl2.c ++++ acpica-unix-20200214/source/components/disassembler/dmresrcl2.c @@ -191,22 +191,24 @@ AcpiDmGpioCommon ( char *DeviceName = NULL; UINT32 PinCount; @@ -3974,10 +3974,10 @@ Index: acpica-unix-20191018/source/components/disassembler/dmresrcl2.c DeviceName = ACPI_ADD_PTR (char, Resource, ResourceSourceOffset); AcpiUtPrintString (DeviceName, ACPI_UINT16_MAX); -Index: acpica-unix-20191018/source/components/disassembler/dmresrcs.c +Index: acpica-unix-20200214/source/components/disassembler/dmresrcs.c =================================================================== ---- acpica-unix-20191018.orig/source/components/disassembler/dmresrcs.c -+++ acpica-unix-20191018/source/components/disassembler/dmresrcs.c +--- acpica-unix-20200214.orig/source/components/disassembler/dmresrcs.c ++++ acpica-unix-20200214/source/components/disassembler/dmresrcs.c @@ -72,6 +72,7 @@ AcpiDmIrqDescriptor ( UINT32 Length, UINT32 Level) @@ -4034,10 +4034,10 @@ Index: acpica-unix-20191018/source/components/disassembler/dmresrcs.c AcpiDmIndent (Level + 1); AcpiDmDumpInteger8 (Resource->FixedIo.AddressLength, "Length"); -Index: acpica-unix-20191018/source/components/dispatcher/dsfield.c +Index: acpica-unix-20200214/source/components/dispatcher/dsfield.c =================================================================== ---- acpica-unix-20191018.orig/source/components/dispatcher/dsfield.c -+++ acpica-unix-20191018/source/components/dispatcher/dsfield.c +--- acpica-unix-20200214.orig/source/components/dispatcher/dsfield.c ++++ acpica-unix-20200214/source/components/dispatcher/dsfield.c @@ -324,6 +324,7 @@ AcpiDsGetFieldNames ( ACPI_STATUS Status; UINT64 Position; @@ -4082,10 +4082,10 @@ Index: acpica-unix-20191018/source/components/dispatcher/dsfield.c if (ACPI_FAILURE (Status)) { ACPI_ERROR_NAMESPACE (WalkState->ScopeInfo, -Index: acpica-unix-20191018/source/components/events/evgpeblk.c +Index: acpica-unix-20200214/source/components/events/evgpeblk.c =================================================================== ---- acpica-unix-20191018.orig/source/components/events/evgpeblk.c -+++ acpica-unix-20191018/source/components/events/evgpeblk.c +--- acpica-unix-20200214.orig/source/components/events/evgpeblk.c ++++ acpica-unix-20200214/source/components/events/evgpeblk.c @@ -380,6 +380,7 @@ AcpiEvCreateGpeBlock ( ACPI_STATUS Status; ACPI_GPE_BLOCK_INFO *GpeBlock; @@ -4118,10 +4118,10 @@ Index: acpica-unix-20191018/source/components/events/evgpeblk.c InterruptNumber == AcpiGbl_FADT.SciInterrupt ? " (SCI)" : "")); /* Update global count of currently available GPEs */ -Index: acpica-unix-20191018/source/components/hardware/hwregs.c +Index: acpica-unix-20200214/source/components/hardware/hwregs.c =================================================================== ---- acpica-unix-20191018.orig/source/components/hardware/hwregs.c -+++ acpica-unix-20191018/source/components/hardware/hwregs.c +--- acpica-unix-20200214.orig/source/components/hardware/hwregs.c ++++ acpica-unix-20200214/source/components/hardware/hwregs.c @@ -197,7 +197,7 @@ AcpiHwValidateRegister ( * Address must not be null. A null address also indicates an optional * ACPI register that is not supported, so no error message. @@ -4131,10 +4131,10 @@ Index: acpica-unix-20191018/source/components/hardware/hwregs.c if (!(*Address)) { return (AE_BAD_ADDRESS); -Index: acpica-unix-20191018/source/components/hardware/hwvalid.c +Index: acpica-unix-20200214/source/components/hardware/hwvalid.c =================================================================== ---- acpica-unix-20191018.orig/source/components/hardware/hwvalid.c -+++ acpica-unix-20191018/source/components/hardware/hwvalid.c +--- acpica-unix-20200214.orig/source/components/hardware/hwvalid.c ++++ acpica-unix-20200214/source/components/hardware/hwvalid.c @@ -135,6 +135,8 @@ AcpiHwValidateIoRequest ( UINT32 ByteWidth; ACPI_IO_ADDRESS LastAddress; @@ -4156,10 +4156,10 @@ Index: acpica-unix-20191018/source/components/hardware/hwvalid.c { ACPI_ERROR ((AE_INFO, "Illegal I/O port address/length above 64K: %8.8X%8.8X/0x%X", -Index: acpica-unix-20191018/source/components/namespace/nsaccess.c +Index: acpica-unix-20200214/source/components/namespace/nsaccess.c =================================================================== ---- acpica-unix-20191018.orig/source/components/namespace/nsaccess.c -+++ acpica-unix-20191018/source/components/namespace/nsaccess.c +--- acpica-unix-20200214.orig/source/components/namespace/nsaccess.c ++++ acpica-unix-20200214/source/components/namespace/nsaccess.c @@ -349,6 +349,7 @@ AcpiNsLookup ( UINT32 SearchParentFlag = ACPI_NS_SEARCH_PARENT; UINT32 LocalFlags; @@ -4180,10 +4180,10 @@ Index: acpica-unix-20191018/source/components/namespace/nsaccess.c AcpiUtGetTypeName (ThisNode->Type), AcpiUtGetTypeName (TypeToCheckFor))); } -Index: acpica-unix-20191018/source/components/namespace/nsparse.c +Index: acpica-unix-20200214/source/components/namespace/nsparse.c =================================================================== ---- acpica-unix-20191018.orig/source/components/namespace/nsparse.c -+++ acpica-unix-20191018/source/components/namespace/nsparse.c +--- acpica-unix-20200214.orig/source/components/namespace/nsparse.c ++++ acpica-unix-20200214/source/components/namespace/nsparse.c @@ -216,13 +216,14 @@ AcpiNsOneCompleteParse ( /* Table must consist of at least a complete header */ @@ -4201,10 +4201,10 @@ Index: acpica-unix-20191018/source/components/namespace/nsparse.c Status = AcpiTbGetOwnerId (TableIndex, &OwnerId); if (ACPI_FAILURE (Status)) -Index: acpica-unix-20191018/source/components/tables/tbdata.c +Index: acpica-unix-20200214/source/components/tables/tbdata.c =================================================================== ---- acpica-unix-20191018.orig/source/components/tables/tbdata.c -+++ acpica-unix-20191018/source/components/tables/tbdata.c +--- acpica-unix-20200214.orig/source/components/tables/tbdata.c ++++ acpica-unix-20200214/source/components/tables/tbdata.c @@ -552,6 +552,7 @@ AcpiTbVerifyTempTable ( UINT32 *TableIndex) { @@ -4223,10 +4223,10 @@ Index: acpica-unix-20191018/source/components/tables/tbdata.c if (ACPI_FAILURE (Status)) { ACPI_EXCEPTION ((AE_INFO, AE_NO_MEMORY, -Index: acpica-unix-20191018/source/components/tables/tbfadt.c +Index: acpica-unix-20200214/source/components/tables/tbfadt.c =================================================================== ---- acpica-unix-20191018.orig/source/components/tables/tbfadt.c -+++ acpica-unix-20191018/source/components/tables/tbfadt.c +--- acpica-unix-20200214.orig/source/components/tables/tbfadt.c ++++ acpica-unix-20200214/source/components/tables/tbfadt.c @@ -424,18 +424,20 @@ AcpiTbCreateLocalFadt ( ACPI_TABLE_HEADER *Table, UINT32 Length) @@ -4338,10 +4338,10 @@ Index: acpica-unix-20191018/source/components/tables/tbfadt.c "PmRegisters", 0); } } -Index: acpica-unix-20191018/source/components/tables/tbfind.c +Index: acpica-unix-20200214/source/components/tables/tbfind.c =================================================================== ---- acpica-unix-20191018.orig/source/components/tables/tbfind.c -+++ acpica-unix-20191018/source/components/tables/tbfind.c +--- acpica-unix-20200214.orig/source/components/tables/tbfind.c ++++ acpica-unix-20200214/source/components/tables/tbfind.c @@ -108,8 +108,11 @@ AcpiTbFindTable ( (void) AcpiUtAcquireMutex (ACPI_MTX_TABLES); for (i = 0; i < AcpiGbl_RootTableList.CurrentTableCount; ++i) @@ -4355,10 +4355,10 @@ Index: acpica-unix-20191018/source/components/tables/tbfind.c { /* Not the requested table */ -Index: acpica-unix-20191018/source/components/tables/tbprint.c +Index: acpica-unix-20200214/source/components/tables/tbprint.c =================================================================== ---- acpica-unix-20191018.orig/source/components/tables/tbprint.c -+++ acpica-unix-20191018/source/components/tables/tbprint.c +--- acpica-unix-20200214.orig/source/components/tables/tbprint.c ++++ acpica-unix-20200214/source/components/tables/tbprint.c @@ -143,15 +143,18 @@ AcpiTbPrintTableHeader ( ACPI_TABLE_HEADER *Header) { @@ -4400,10 +4400,10 @@ Index: acpica-unix-20191018/source/components/tables/tbprint.c } } -Index: acpica-unix-20191018/source/components/tables/tbutils.c +Index: acpica-unix-20200214/source/components/tables/tbutils.c =================================================================== ---- acpica-unix-20191018.orig/source/components/tables/tbutils.c -+++ acpica-unix-20191018/source/components/tables/tbutils.c +--- acpica-unix-20200214.orig/source/components/tables/tbutils.c ++++ acpica-unix-20200214/source/components/tables/tbutils.c @@ -238,7 +238,7 @@ AcpiTbGetRootTableEntry ( * 64-bit platform, XSDT: Move (unaligned) 64-bit to local, * return 64-bit @@ -4463,10 +4463,10 @@ Index: acpica-unix-20191018/source/components/tables/tbutils.c { AcpiGbl_FadtIndex = TableIndex; AcpiTbParseFadt (); -Index: acpica-unix-20191018/source/components/tables/tbxface.c +Index: acpica-unix-20200214/source/components/tables/tbxface.c =================================================================== ---- acpica-unix-20191018.orig/source/components/tables/tbxface.c -+++ acpica-unix-20191018/source/components/tables/tbxface.c +--- acpica-unix-20200214.orig/source/components/tables/tbxface.c ++++ acpica-unix-20200214/source/components/tables/tbxface.c @@ -293,8 +293,11 @@ AcpiGetTableHeader ( for (i = 0, j = 0; i < AcpiGbl_RootTableList.CurrentTableCount; i++) @@ -4480,10 +4480,10 @@ Index: acpica-unix-20191018/source/components/tables/tbxface.c { continue; } -Index: acpica-unix-20191018/source/components/tables/tbxfload.c +Index: acpica-unix-20200214/source/components/tables/tbxfload.c =================================================================== ---- acpica-unix-20191018.orig/source/components/tables/tbxfload.c -+++ acpica-unix-20191018/source/components/tables/tbxfload.c +--- acpica-unix-20200214.orig/source/components/tables/tbxfload.c ++++ acpica-unix-20200214/source/components/tables/tbxfload.c @@ -153,6 +153,7 @@ AcpiTbLoadNamespace ( ACPI_TABLE_DESC *Table; UINT32 TablesLoaded = 0; @@ -4503,10 +4503,10 @@ Index: acpica-unix-20191018/source/components/tables/tbxfload.c ACPI_FAILURE (AcpiTbValidateTable (Table))) { Status = AE_NO_ACPI_TABLES; -Index: acpica-unix-20191018/source/tools/acpiexec/aetables.c +Index: acpica-unix-20200214/source/tools/acpiexec/aetables.c =================================================================== ---- acpica-unix-20191018.orig/source/tools/acpiexec/aetables.c -+++ acpica-unix-20191018/source/tools/acpiexec/aetables.c +--- acpica-unix-20200214.orig/source/tools/acpiexec/aetables.c ++++ acpica-unix-20200214/source/tools/acpiexec/aetables.c @@ -146,21 +146,25 @@ AeInitializeTableHeader ( char *Signature, UINT32 Length) @@ -4658,10 +4658,10 @@ Index: acpica-unix-20191018/source/tools/acpiexec/aetables.c } return (AE_OK); -Index: acpica-unix-20191018/source/common/dmswitch.c +Index: acpica-unix-20200214/source/common/dmswitch.c =================================================================== ---- acpica-unix-20191018.orig/source/common/dmswitch.c -+++ acpica-unix-20191018/source/common/dmswitch.c +--- acpica-unix-20200214.orig/source/common/dmswitch.c ++++ acpica-unix-20200214/source/common/dmswitch.c @@ -88,13 +88,15 @@ AcpiDmProcessSwitch ( ACPI_PARSE_OBJECT_LIST *Current; ACPI_PARSE_OBJECT_LIST *Previous; diff --git a/converterSample.asl.result b/converterSample.asl.result index fd63f11..47c532c 100644 --- a/converterSample.asl.result +++ b/converterSample.asl.result @@ -1,11 +1,11 @@ converterSample.asl 37: Method(MAIN) { -Remark 2120 - ^ Control Method should be made Serialized (due to creation of named objects within) +Remark 2120 - ^ Control Method should be made Serialized due to creation of named objects within (\MAIN) converterSample.asl 48: Name(b,0); Remark 2089 - Object is not referenced ^ (Name [B___] is within a method [MAIN]) converterSample.asl 65: Method(SCOP) -Remark 2120 - ^ Control Method should be made Serialized (due to creation of named objects within) +Remark 2120 - ^ Control Method should be made Serialized due to creation of named objects within (\SCOP) converterSample.asl 68: Name (a1, 0x04) Remark 2089 - Object is not referenced ^ (Name [A1__] is within a method [SCOP]) @@ -16,9 +16,11 @@ Remark 2158 - ^ Unnecessary/redundant use of Offset Intel ACPI Component Architecture ASL+ Optimizing Compiler/Disassembler version VVVVVVVV -Copyright (c) 2000 - 2019 Intel Corporation +Copyright (c) 2000 - 2020 Intel Corporation + +Ignoring all errors, forcing AML file generation ASL Input: converterSample.asl - 1968 bytes 11 keywords 85 source lines -AML Output: converterSample.aml - 180 bytes 2 opcodes 9 named objects +AML Output: converterSample.aml - 182 bytes 2 opcodes 9 named objects -Compilation successful. 0 Errors, 0 Warnings, 5 Remarks, 12 Optimizations, 1 Constants Folded +Compilation successful. 0 Errors, 0 Warnings, 5 Remarks, 10 Optimizations diff --git a/f23-harden.patch b/f23-harden.patch index c719d07..eacb454 100644 --- a/f23-harden.patch +++ b/f23-harden.patch @@ -8,10 +8,10 @@ From: Al Stone generate/unix/iasl/Makefile | 13 +++++++------ 2 files changed, 9 insertions(+), 6 deletions(-) -Index: acpica-unix-20191018/generate/unix/Makefile.config +Index: acpica-unix-20200214/generate/unix/Makefile.config =================================================================== ---- acpica-unix-20191018.orig/generate/unix/Makefile.config -+++ acpica-unix-20191018/generate/unix/Makefile.config +--- acpica-unix-20200214.orig/generate/unix/Makefile.config ++++ acpica-unix-20200214/generate/unix/Makefile.config @@ -190,6 +190,8 @@ ifneq ($(NOFORTIFY),TRUE) OPT_CFLAGS += -D_FORTIFY_SOURCE=2 endif @@ -19,12 +19,12 @@ Index: acpica-unix-20191018/generate/unix/Makefile.config +OPT_CFLAGS += -fPIC -pie + CFLAGS += \ - -D$(HOST)\ + -D$(ACPI_HOST)\ -D_GNU_SOURCE\ -Index: acpica-unix-20191018/generate/unix/iasl/Makefile +Index: acpica-unix-20200214/generate/unix/iasl/Makefile =================================================================== ---- acpica-unix-20191018.orig/generate/unix/iasl/Makefile -+++ acpica-unix-20191018/generate/unix/iasl/Makefile +--- acpica-unix-20200214.orig/generate/unix/iasl/Makefile ++++ acpica-unix-20200214/generate/unix/iasl/Makefile @@ -358,34 +358,35 @@ $(OBJDIR)/prparserparse.c $(OBJDIR)/prpa # Cannot use the common compile warning flags since the C files are created # by the utilities above and they are not necessarily ANSI C, etc. diff --git a/grammar.asl.result b/grammar.asl.result index e5ac529..c4b9c48 100644 --- a/grammar.asl.result +++ b/grammar.asl.result @@ -19,9 +19,15 @@ Warning 3133 - ^ Unknown reserved name (_NPK) grammar.asl 208: Device (RES) Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) +grammar.asl 247: Name (PRT0, ResourceTemplate () +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\RES._CRS) + grammar.asl 399: CreateByteField (PRT0, R000._ASZ, RSIZ) Remark 2089 - Object is not referenced ^ (Name [RSIZ] is within a method [_CRS]) +grammar.asl 406: Name (BUF0, ResourceTemplate () +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\RES._PRS) + grammar.asl 513: Name (_STR, Unicode ("test")) Remark 2089 - ^ Object is not referenced (Name [_STR] is within a method [TCOP]) @@ -70,6 +76,9 @@ Remark 2089 - Object is not referenced ^ (Name [FL grammar.asl 705: Device(PCI0) Warning 3073 - Multiple types ^ (Device object requires either a _HID or _ADR, but not both) +grammar.asl 712: Name(PRT0, ResourceTemplate() { +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.PCI0._CRS) + grammar.asl 733: Method(_SRS) Warning 3102 - ^ Reserved method has too few arguments (_SRS requires 1) @@ -100,9 +109,21 @@ Remark 2146 - ^ Method Argument is never used (Arg0) grammar.asl 1300: Name(BUFR, Buffer (Local0) {}) Remark 2089 - ^ Object is not referenced (Name [BUFR] is within a method [OBJ1]) +grammar.asl 1300: Name(BUFR, Buffer (Local0) {}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\OBJ1) + +grammar.asl 1301: Name(BUF1, Buffer (4) {1,2,3,4}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\OBJ1) + +grammar.asl 1302: Name(BUF2, Buffer (4) {}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\OBJ1) + grammar.asl 1307: Alias (MTX1, MTX2) Remark 2089 - Object is not referenced ^ (Name [MTX2] is within a method [OBJ1]) +grammar.asl 1321: Name (BUF2, Buffer (128) {}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\FLDS) + grammar.asl 1329: CreateField (BUF2, 148, 96, FLD3) Remark 2089 - Object is not referenced ^ (Name [FLD3] is within a method [FLDS]) @@ -112,9 +133,33 @@ Warning 3038 - ^ Truncating 64-bit constant grammar.asl 1396: if (LNotEqual (Local0, 0x1234567887654321)) Warning 3038 - Truncating 64-bit constant found in 32-bit table ^ +grammar.asl 1411: Field (\_SB_.MEM.SMEM, AnyAcc, NoLock, Preserve) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\FLDX) + +grammar.asl 1418: Field (\_SB_.MEM.SMEM, AnyAcc, NoLock, Preserve) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\FLDX) + +grammar.asl 1445: Name (BUFO, Buffer (32) {}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\OBJ2) + +grammar.asl 1448: OperationRegion (OPR2, SystemMemory, Arg0, 256) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\OBJ2) + +grammar.asl 1451: Field (OPR2, ByteAcc, NoLock, Preserve) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\OBJ2) + +grammar.asl 1462: BankField (OPR2, BNK2, 0, ByteAcc, NoLock, Preserve) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\OBJ2) + +grammar.asl 1469: IndexField (IDX2, DAT2, ByteAcc, NoLock, Preserve) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\OBJ2) + grammar.asl 1476: SizeOf (BUFO) Error 6114 - ^ Result is not used, operator has no effect +grammar.asl 1490: Event (EVT2) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\OBJ2) + grammar.asl 1496: Alias (MTX2, MTXA) Remark 2089 - Object is not referenced ^ (Name [MTXA] is within a method [OBJ2]) @@ -146,7 +191,13 @@ grammar.asl 1792: Store (LLessEqual (0xFFFFFFFF, 0x11111111), Local5) Warning 3144 - Method Local is set but never used ^ (Local5) grammar.asl 1821: Method (COND) -Warning 3115 - ^ Not all control paths return a value (COND) +Warning 3115 - ^ Not all control paths return a value (\COND) + +grammar.asl 1916: Name (BBUF, Buffer() {0xB0, 0xB1, 0xB2, 0xB3, 0xB4, 0xB5, 0xB6, 0xB7}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\REFS) + +grammar.asl 1918: Name (NEST, Package () +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\REFS) grammar.asl 1930: Store (RefOf (MAIN), Local5) Warning 3144 - Method Local is set but never used ^ (Local5) @@ -157,6 +208,9 @@ Warning 3141 - ^ Missing dependency (Device object requires a grammar.asl 2162: Device (NOSV) Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) +grammar.asl 2168: Name (WRD, 0x1234) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\NOSV.TEST) + grammar.asl 2583: Device (IDXF) Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) @@ -175,6 +229,12 @@ Warning 3141 - Missing dependency ^ (Device object requires a _HID or _ADR grammar.asl 2658: Device (RTBF) Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) +grammar.asl 2667: Name (ABUF, Buffer() {"ARBITRARY_BUFFER"}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\RTBF.RBUF) + +grammar.asl 2695: Name (BUFR, Buffer(Local1) {}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\RTBF.RBUF) + grammar.asl 2756: Device (GPE2) Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) @@ -205,15 +265,36 @@ Warning 3141 - ^ Missing dependency (Device object requires a grammar.asl 3109: Device (ANDO) Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) +grammar.asl 3343: Name(RSLT,1) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\ANDO.TEST) + grammar.asl 3383: Device (BRKP) Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) grammar.asl 3420: Device (ADSU) Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) +grammar.asl 3435: Name (DWRD, 0x12345678) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\ADSU.TEST) + +grammar.asl 3436: Name (WRD, 0x1234) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\ADSU.TEST) + +grammar.asl 3437: Name (BYT, 0x12) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\ADSU.TEST) + grammar.asl 3513: Device (INDC) Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) +grammar.asl 3528: Name (DWRD, 0x12345678) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\INDC.TEST) + +grammar.asl 3529: Name (WRD, 0x1234) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\INDC.TEST) + +grammar.asl 3530: Name (BYT, 0x12) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\INDC.TEST) + grammar.asl 3611: Device (LOPS) Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) @@ -223,6 +304,18 @@ Warning 3141 - ^ Missing dependency (Device object requires a grammar.asl 4120: Device (MLDV) Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) +grammar.asl 4135: Name (RMDR, 0) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\MLDV.TEST) + +grammar.asl 4136: Name (DWRD, 0x12345678) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\MLDV.TEST) + +grammar.asl 4137: Name (WRD, 0x1234) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\MLDV.TEST) + +grammar.asl 4138: Name (BYT, 0x12) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\MLDV.TEST) + grammar.asl 4253: Device (NBIT) Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) @@ -232,12 +325,33 @@ Warning 3141 - ^ Missing dependency (Device object requires a grammar.asl 4685: Device (XORD) Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) +grammar.asl 4693: OperationRegion (RAM, SystemMemory, 0x800000, 256) +Warning 3175 - ^ Static OperationRegion should be declared outside control method + +grammar.asl 4693: OperationRegion (RAM, SystemMemory, 0x800000, 256) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\XORD.TEST) + +grammar.asl 4694: Field (RAM, ByteAcc, NoLock, Preserve) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\XORD.TEST) + grammar.asl 5022: Device (CRBF) Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) grammar.asl 5100: Device (IDX4) Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) +grammar.asl 5117: OperationRegion (RAM, SystemMemory, Arg0, 0x100) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\IDX4.MADM) + +grammar.asl 5118: Field (RAM, DwordAcc, NoLock, Preserve) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\IDX4.MADM) + +grammar.asl 5123: Field (RAM, ByteAcc, NoLock, Preserve) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\IDX4.MADM) + +grammar.asl 5159: Field (RAM, ByteAcc, NoLock, Preserve) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\IDX4.MADM) + grammar.asl 5639: Device (EVNT) Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) @@ -307,30 +421,99 @@ Warning 3144 - Method Local is set but never used ^ (Local6) grammar.asl 6393: Device (IDX5) Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) +grammar.asl 6416: Name (BUF0, Buffer (Local0) {}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\IDX5.MCTH) + +grammar.asl 6417: Name (BUF1, Buffer (Local0) {}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\IDX5.MCTH) + grammar.asl 6474: Device (PCI2) Warning 3073 - Multiple types ^ (Device object requires either a _HID or _ADR, but not both) grammar.asl 6478: Name (_CRS, Buffer(26) {"\_SB_.PCI2._CRS..........."}) Warning 3046 - Invalid or unknown escape sequence ^ +grammar.asl 6554: Name (BUFR, Package(13) {}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.IDX0._BIF) + +grammar.asl 6578: Name (BUFR, Package(4) {1, 0x100, 0x76543210, 0x180}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.IDX0._BST) + +grammar.asl 6593: Name (PBUF, Package(4) {}) // leave uninitialized +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.IDX0.TEST) + +grammar.asl 6625: Name (BUFR, Buffer(16) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.IDX0.TEST) + grammar.asl 6709: Device (BITI) Warning 3141 - Missing dependency ^ (Device object requires a _HID or _ADR in same scope) grammar.asl 6817: And (Local0, 1, Local0) // Local0 &= 1 Error 6066 - ^ Method local variable is not initialized (Local0) +grammar.asl 6846: Name (C17C, Package (13) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.C17B) + grammar.asl 6903: Name (_HID, "*PNP0C0A") // Control Method Battey ID Error 6061 - Invalid leading asterisk ^ (*PNP0C0A) grammar.asl 6912: Device (IDX3) Warning 3141 - Missing dependency ^ (Device object requires a _HID or _ADR in same scope) +grammar.asl 6922: Name (BUFR, Buffer () {0, 1, 2, 3, 4, 5, 6, 7, 8, 9}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.IDX3.LCLB) + +grammar.asl 6974: Name (PKG, Package () {0, 1, 2, 3, 4, 5, 6, 7, 8, 9}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.IDX3.LCLP) + grammar.asl 7057: Device(IDX7) Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) +grammar.asl 7074: Name (DEST, Buffer () // 62 characters plus NULL +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\IDX7.TST1) + +grammar.asl 7093: Name (BUF0, Buffer() {0x1, 0x2, 0x3, 0x4, 0x5}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\IDX7.TST2) + +grammar.asl 7110: Name (BUF1, Buffer() {0x1, 0x2, 0x3, 0x4, 0x5}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\IDX7.TST3) + +grammar.asl 7301: Name (SRCB, Buffer (12) {}) // 12 characters +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\IDX7.TSTF) + +grammar.asl 7304: Name (DEST, Buffer () // 62 characters plus NULL +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\IDX7.TSTF) + +grammar.asl 7327: Name (SRCB, Buffer (12) {}) // 12 characters +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\IDX7.TSTG) + +grammar.asl 7330: Name (DEST, Buffer () // 62 characters plus NULL +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\IDX7.TSTG) + +grammar.asl 7412: Name (DBUF, Buffer () {"abcdefghijklmnopqrstuvwxyz"}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\IDX7.TSTH) + +grammar.asl 7448: Name (DBUF, Buffer () {"abcdefghijklmnopqrstuvwxyz"}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\IDX7.TSTI) + +grammar.asl 7484: Name (DBUF, Buffer () {"abcdefghijklmnopqrstuvwxyz"}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\IDX7.TSTJ) + +grammar.asl 7520: Name (DBUF, Buffer () {"abcdefghijklmnopqrstuvwxyz"}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\IDX7.TSTK) + +grammar.asl 7556: Name (DBUF, Buffer () {"abcdefghijklmnopqrstuvwxyz"}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\IDX7.TSTL) + grammar.asl 7736: Device (MTCH) Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) +grammar.asl 7743: Name (TIM0, Package () +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\MTCH.TEST) + +grammar.asl 7755: Name (TMD0, Buffer (20) {0xFF, 0xFF, 0xFF, 0xFF }) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\MTCH.TEST) + grammar.asl 7757: CreateDWordField (TMD0, 4, DMA0) Remark 2089 - Object is not referenced ^ (Name [DMA0] is within a method [TEST]) @@ -346,15 +529,51 @@ Remark 2089 - Object is not referenced ^ (Name [CHNF] is grammar.asl 7934: Device (WHLB) Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) +grammar.asl 8275: Name (BUFR, Package (13) {}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.BAT1._BIF) + grammar.asl 8295: Device (IDX2) Warning 3141 - Missing dependency ^ (Device object requires a _HID or _ADR in same scope) +grammar.asl 8300: Name (SRCB, Buffer () {"Short Buffer"}) // 12 characters plus NULL +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.IDX2.B2IB) + +grammar.asl 8302: Name (DEST, Buffer () // 62 characters plus NULL +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.IDX2.B2IB) + +grammar.asl 8493: Name (DEST, Package (2) {}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.IDX2.FB2P) + grammar.asl 8678: Device (SIZO) Warning 3141 - ^ Missing dependency (Device object requires a _HID or _ADR in same scope) +grammar.asl 8708: Name (BUFR, Buffer (12) {}) // uninitialized Buffer +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\SIZO.SARG) + +grammar.asl 8709: Name (BUF1, Buffer() {0x01, 0x02, 0x03, 0x04, 0x05}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\SIZO.SARG) + +grammar.asl 8710: Name (PKG0, Package (4) {}) // uninitialized Package +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\SIZO.SARG) + +grammar.asl 8712: Name (PKG1, Package (4) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\SIZO.SARG) + grammar.asl 8720: Name (PKG2, Package (4) Remark 2063 - ^ Initializer list shorter than declared package length +grammar.asl 8720: Name (PKG2, Package (4) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\SIZO.SARG) + +grammar.asl 8973: Name (BUFR, Buffer (12) {}) +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\SIZO.SBUF) + +grammar.asl 9034: Name (BUFR, Buffer (12) {}) // uninitialized Buffer +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\SIZO.SLOC) + +grammar.asl 9036: Name (PKG0, Package (4) {}) // uninitialized Package +Remark 2173 - ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\SIZO.SLOC) + grammar.asl 9132: Store (_OS, Local0) Warning 3144 - ^ Method Local is set but never used (Local0) @@ -376,11 +595,11 @@ Warning 3141 - Missing dependency ^ (Device object requires a _HID or _ADR i Intel ACPI Component Architecture ASL+ Optimizing Compiler/Disassembler version VVVVVVVV -Copyright (c) 2000 - 2019 Intel Corporation +Copyright (c) 2000 - 2020 Intel Corporation Ignoring all errors, forcing AML file generation ASL Input: grammar.asl - 323653 bytes 4818 keywords 10284 source lines AML Output: grammar.aml - 43758 bytes 4148 opcodes 670 named objects -Compilation successful. 6 Errors, 92 Warnings, 27 Remarks, 1106 Optimizations +Compilation successful. 6 Errors, 93 Warnings, 99 Remarks, 1106 Optimizations diff --git a/sources b/sources index 35345a6..3ad2f69 100644 --- a/sources +++ b/sources @@ -1,2 +1,2 @@ -SHA512 (acpica-unix2-20200110.tar.gz) = 5c7ab7d514a06dabbec75131bd6fc2fbcbc4e92b8a1fe63e45ccc90631556584b2dbbf96b3f945e8ab1eff40e5b0c9de96395aeed1cfd2bd03ec92d8442fed32 -SHA512 (acpitests-unix-20200110.tar.gz) = f3fd79de9df58e6d6f59a2c31d7b109a39b29b744a15e885af9cd44a765ee1cc85f7eb8314f7b00552b53898db555357d839e844c6c966488ae9a52d1ebff606 +SHA512 (acpica-unix2-20200214.tar.gz) = 0b22f8c8255b030b5e8a2cf5b459344d1f644b26a4fcf1e95b3682335204598a3587f8f2a5ac169f99d76a10ae529051e1dabd1672c8d8bf5a4441c71d4cb1fd +SHA512 (acpitests-unix-20200214.tar.gz) = b4d37d4784d3fbb697f244477c085e433efa152bc4c4a06d336b216358405252a77c331f4e792f5fa9b912d6f5f200aa1b6379f1b5064e58be12cf8d4415ee15 diff --git a/str-trunc-warn.patch b/str-trunc-warn.patch index a62a34a..763ae68 100644 --- a/str-trunc-warn.patch +++ b/str-trunc-warn.patch @@ -1,8 +1,8 @@ -Index: acpica-unix-20191018/source/compiler/aslanalyze.c +Index: acpica-unix-20200214/source/compiler/aslanalyze.c =================================================================== ---- acpica-unix-20191018.orig/source/compiler/aslanalyze.c -+++ acpica-unix-20191018/source/compiler/aslanalyze.c -@@ -355,11 +355,16 @@ AnCheckMethodReturnValue ( +--- acpica-unix-20200214.orig/source/compiler/aslanalyze.c ++++ acpica-unix-20200214/source/compiler/aslanalyze.c +@@ -358,11 +358,16 @@ AnCheckMethodReturnValue ( */ if (ThisNodeBtype != 0) { @@ -20,11 +20,11 @@ Index: acpica-unix-20191018/source/compiler/aslanalyze.c + free(strp); } } - } -Index: acpica-unix-20191018/source/compiler/aslpredef.c + +Index: acpica-unix-20200214/source/compiler/aslpredef.c =================================================================== ---- acpica-unix-20191018.orig/source/compiler/aslpredef.c -+++ acpica-unix-20191018/source/compiler/aslpredef.c +--- acpica-unix-20200214.orig/source/compiler/aslpredef.c ++++ acpica-unix-20200214/source/compiler/aslpredef.c @@ -159,14 +159,19 @@ ApCheckForPredefinedMethod ( if (MethodInfo->NumReturnNoValue && ThisName->Info.ExpectedBtypes) @@ -84,10 +84,10 @@ Index: acpica-unix-20191018/source/compiler/aslpredef.c return (AE_TYPE); } -Index: acpica-unix-20191018/source/compiler/aslwalks.c +Index: acpica-unix-20200214/source/compiler/aslwalks.c =================================================================== ---- acpica-unix-20191018.orig/source/compiler/aslwalks.c -+++ acpica-unix-20191018/source/compiler/aslwalks.c +--- acpica-unix-20200214.orig/source/compiler/aslwalks.c ++++ acpica-unix-20200214/source/compiler/aslwalks.c @@ -515,15 +515,19 @@ AnOperandTypecheckWalkEnd ( else if (!CommonBtypes) {