|
 |
0b651cb |
From 783a85a5161335f6722e132cc6fcb030054766e7 Mon Sep 17 00:00:00 2001
|
|
|
0b651cb |
From: Jakub Filak <jfilak@redhat.com>
|
|
|
0b651cb |
Date: Wed, 1 Oct 2014 17:14:50 +0200
|
|
|
0b651cb |
Subject: [PATCH] applet: confirm ignoring of notifications
|
|
|
0b651cb |
|
|
|
0b651cb |
and fix a bug in abrt-action-notify
|
|
|
0b651cb |
|
|
|
0b651cb |
Related to rhbz#1084031
|
|
|
0b651cb |
|
|
|
0b651cb |
Signed-off-by: Jakub Filak <jfilak@redhat.com>
|
|
|
0b651cb |
---
|
|
|
0b651cb |
src/applet/applet.c | 16 +++++++++++++---
|
|
|
0b651cb |
src/plugins/abrt-action-notify | 2 +-
|
|
|
0b651cb |
2 files changed, 14 insertions(+), 4 deletions(-)
|
|
|
0b651cb |
|
|
|
0b651cb |
diff --git a/src/applet/applet.c b/src/applet/applet.c
|
|
|
0b651cb |
index 27c5fad..1618d8c 100644
|
|
|
0b651cb |
--- a/src/applet/applet.c
|
|
|
0b651cb |
+++ b/src/applet/applet.c
|
|
|
0b651cb |
@@ -667,9 +667,19 @@ static void action_ignore(NotifyNotification *notification, gchar *action, gpoin
|
|
|
0b651cb |
{
|
|
|
0b651cb |
problem_info_t *pi = (problem_info_t *)user_data;
|
|
|
0b651cb |
|
|
|
0b651cb |
- log_debug("Ignoring problem '%s'", problem_info_get_dir(pi));
|
|
|
0b651cb |
-
|
|
|
0b651cb |
- ignored_problems_add_problem_data(g_ignore_set, pi->problem_data);
|
|
|
0b651cb |
+ const char *const message = _(
|
|
|
0b651cb |
+ "You are going to mute notifications of a particular problem. " \
|
|
|
0b651cb |
+ "You will never see a notification bubble for this problem again, " \
|
|
|
0b651cb |
+ "however, ABRT will be detecting it and you will be able " \
|
|
|
0b651cb |
+ "to report it from ABRT GUI." \
|
|
|
0b651cb |
+ "\n\n" \
|
|
|
0b651cb |
+ "Do you want to continue?");
|
|
|
0b651cb |
+
|
|
|
0b651cb |
+ if (run_ask_yes_no_yesforever_dialog("AskIgnoreForever", message, NULL))
|
|
|
0b651cb |
+ {
|
|
|
0b651cb |
+ log_debug("Ignoring problem '%s'", problem_info_get_dir(pi));
|
|
|
0b651cb |
+ ignored_problems_add_problem_data(g_ignore_set, pi->problem_data);
|
|
|
0b651cb |
+ }
|
|
|
0b651cb |
|
|
|
0b651cb |
GError *err = NULL;
|
|
|
0b651cb |
notify_notification_close(notification, &err;;
|
|
|
0b651cb |
diff --git a/src/plugins/abrt-action-notify b/src/plugins/abrt-action-notify
|
|
|
0b651cb |
index cbabf74..8b8f38e 100644
|
|
|
0b651cb |
--- a/src/plugins/abrt-action-notify
|
|
|
0b651cb |
+++ b/src/plugins/abrt-action-notify
|
|
|
0b651cb |
@@ -99,7 +99,7 @@ def emit_crash_dbus_signal(problem_data):
|
|
|
0b651cb |
# member is a Boolean flag which is True if the element is required
|
|
|
0b651cb |
arguments = ((FILENAME_PACKAGE, True), (CD_DUMPDIR, True),
|
|
|
0b651cb |
(FILENAME_UID, False), (FILENAME_UUID, False),
|
|
|
0b651cb |
- (FILENAME_PACKAGE, False))
|
|
|
0b651cb |
+ (FILENAME_DUPHASH, False))
|
|
|
0b651cb |
|
|
|
0b651cb |
for elem in arguments:
|
|
|
0b651cb |
itm = problem_data.get(elem[0])
|
|
|
0b651cb |
--
|
|
|
0b651cb |
1.9.3
|
|
|
0b651cb |
|