#1 Update to latest git snapshot
Merged 4 years ago by jjames. Opened 4 years ago by somlo.
rpms/ somlo/abc master  into  master

Update to latest git snapshot
Gabriel Somlo • 4 years ago  
file removed
-10
@@ -1,10 +0,0 @@ 

- --- src/aig/gia/module.make.orig	2019-12-17 15:57:46.000000000 -0700

- +++ src/aig/gia/module.make	2019-12-18 09:15:32.619098847 -0700

- @@ -16,6 +16,7 @@ SRC +=    src/aig/gia/giaAig.c \

-      src/aig/gia/giaCSat2.c \

-      src/aig/gia/giaCTas.c \

-      src/aig/gia/giaCut.c \

- +    src/aig/gia/giaDeep.c \

-      src/aig/gia/giaDfs.c \

-      src/aig/gia/giaDup.c \

-      src/aig/gia/giaEdge.c \

file modified
+6 -5
@@ -1,8 +1,8 @@ 

  # Upstream doesn't make releases.  We have to check the code out of git.

  %global owner    berkeley-abc

- %global gittag   02393a2a7af6b45766830f111923cb2f56f28dad

+ %global gittag   8eb6aed5d116afc0933b49c6973af08cf2eff471

  %global shorttag %(cut -b -7 <<< %{gittag})

- %global gitdate  20191217

+ %global gitdate  20200127

  

  # WARNING: When updating to a newer snapshot, because upstream doesn't do

  # shared library versioning, run abipkgdiff (from libabigail) against the
@@ -20,7 +20,7 @@ 

  

  Name:           abc

  Version:        1.01

- Release:        25.git%{gitdate}%{?dist}

+ Release:        26.git%{gitdate}%{?dist}

  Summary:        Sequential logic synthesis and formal verification

  

  License:        MIT
@@ -39,8 +39,6 @@ 

  Patch3:         %{name}-build.patch

  # Fix sprintf calls that can overflow their buffers

  Patch4:         %{name}-format.patch

- # Fix undefined symbols due to not compiling giaDeep.c

- Patch5:         %{name}-giaDeep.patch

  

  BuildRequires:  cmake

  BuildRequires:  gcc-c++
@@ -132,6 +130,9 @@ 

  %{_libdir}/lib%{name}.so

  

  %changelog

+ * Mon Jan 27 2020 Gabriel Somlo <gsomlo@gmail.com> - 1.01-25.git8eb6aed

+ - Update to latest git snapshot

+ 

  * Tue Jan 28 2020 Fedora Release Engineering <releng@fedoraproject.org> - 1.01-25.git20191217

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild

  

As of Jan. 11, 2020, yosys requires abc git snapshot 71f2b40 or newer.
We can also drop the -giaDeep patch, which has been applied upstream.

Signed-off-by: Gabriel Somlo gsomlo@gmail.com

Thanks for the update, Gabriel. Let me check whether this update requires a cvc4 rebuild, and I'll get this going. If you are interested in comaintaining abc, let me know.

Pull-Request has been merged by jjames

4 years ago

I'd be happy to co-maintain abc. I'm co-maintaining yosys, which depends on abc, so that should work out nicely.

Thanks!

I've added you as comaintainer. I only ask that if you update abc, please check whether cvc4 needs a rebuild. Thanks!

Thanks. I've dug around a bit (not familiar with cvc4), so it appears it (cvc4) lists abc-devel as a build dependency. How do you typically determine whether or not a new abc git revision should trigger a cvc4 rebuild? (If this line of inquiry gives you anxiety, please feel free to remove me as an abc co-maintainer :) I'm happy to submit PRs here if yosys upstream decides they want a fresher abc than what's currently available. OTOH, if the cvc4 thing is an easy explanation, happy to stick around and co-maintain abc -- totally your call.

Thanks again,
--G

I run abipkgdiff on the previous and new abc builds, as described at the top of abc.spec. Hmmm, actually those directions are not quite right. I'll commit a fix to them in a moment. Anyway, added functions and variables can be ignored. What I do is look at the list of removed and changed functions and variables, then grep the cvc4 sources to see if any of them are used. If not, no problem. If so, then cvc4 needs a rebuild.

Well, if something cvc4 uses actually gets removed then we'll have to do something more drastic than a rebuild. :-)