PR#1: Add emacs-cython-mode subpackage - rpms/Cython

rpms / Cython

#1 Add emacs-cython-mode subpackage

Closed 5 years ago by churchyard. Opened 6 years ago by acobb.

Unknown source emacs-cython-mode into master

Fix files for emacs-cython-mode

Alex Cobb • 5 years ago

5bb10df

Bug fixes

Alex Cobb • 5 years ago

8f120ae

Add emacs-cython-mode subpackage

Alex Cobb • 5 years ago

be01f61

Cython.spec

file modified

+29 -2

		`@@ -7,7 +7,7 @@`
		`Name: Cython`
		`%global upver 0.29.1`
		`Version: 0.29.1`
		`- Release: 1%{?dist}`
		`+ Release: 2%{?dist}`
		`Summary: Language for writing Python extension modules`

		`License: ASL 2.0`
		`@@ -59,12 +59,26 @@`

		`Python 3 version.`

		`+ %package -n emacs-cython-mode`
		`+ Summary: A major mode for editing Cython source files in Emacs`
		`+ BuildArch: noarch`
		`+ BuildRequires: emacs`
		`+ Requires: emacs(bin) >= %{_emacs_version}`
		`+`
		`+ %description -n emacs-cython-mode`
		`+ cython-mode is an Emacs major mode for editing Cython source files.`
		`+`
		`%prep`
		`%autosetup -n %{upname}-%{upver} -p1`

		`%build`
		`%py2_build`
		`%py3_build`
		`+ # emacs-cython-mode build`
		`+ echo ";;`
		`+ (require 'cython-mode)" > cython-mode-init.el`
		`+ cp -p Tools/cython-mode.el .`
		`+ %{_emacs_bytecompile} *.el`

		`%install`
		`%py2_install`
		`@@ -75,6 +89,12 @@`
		`rm -rf %{buildroot}%{python3_sitelib}/setuptools/tests`


		`+ # emacs-cython-mode install`
		`+ mkdir -p %{buildroot}%{_emacs_sitelispdir}/`
		`+ cp -p cython-mode.el cython-mode.elc %{buildroot}%{_emacs_sitelispdir}/`
		`+ mkdir -p %{buildroot}%{_emacs_sitestartdir}/`
		`+ cp -p cython-mode-init.el cython-mode-init.elc %{buildroot}%{_emacs_sitestartdir}/`
		`+`
		`%if %{with tests}`
		`%check`
		`%{__python2} runtests.py -vv`
		`@@ -101,7 +121,15 @@`
		`%{python3_sitearch}/%{upname}.py`
		`%{python3_sitearch}/__pycache__/%{upname}.*`

		`+ %files -n emacs-cython-mode`
		`+ %license LICENSE.txt`
		`+ %{_emacs_sitelispdir}/cython.el`
		`+ %{_emacs_sitestartdir}/cython.el`
		`+`
		`%changelog`
		`+ * Tue Jan 08 2019 Alex Cobb <alex.cobb@smart.mit.edu> - 0.29.1-2`
		`+ - Added emacs-cython-mode subpackage.`
		`+`
		`* Mon Dec 10 2018 Igor Gnatenko <ignatenkobrain@fedoraproject.org> - 0.29.1-1`
		`- Update to 0.29.1`

		`@@ -382,4 +410,3 @@`

		`* Tue Feb 26 2008 Neal Becker <ndbecker2@gmail.com> - 0.9.6.12-1`
		`- Initial version`
		`-`

acobb commented 6 years ago

Pull request as requested, see https://bugzilla.redhat.com/show_bug.cgi?id=1484749

churchyard commented 5 years ago

Is this still desired?

Please rebase (and I'll happily review and merge) or close.

rebased onto be01f61

5 years ago

acobb commented 5 years ago

@churchyard Rebased, thank you! Look forward to your comments.

(I'm a non-packager and couldn't have done the merge at all without your comments on fedora-infrastructure #6361 -- thanks)

churchyard commented on line 42 of Cython.spec 5 years ago

why is this line needed?

churchyard commented on line 57 of Cython.spec 5 years ago

not _emacs_sitestartdir as well?

churchyard commented 5 years ago

https://koji.fedoraproject.org/koji/taskinfo?taskID=31887257

1 new commit added

Bug fixes

5 years ago

acobb commented 5 years ago

not _emacs_sitestartdir as well?

I see.... because _emacs_sitestartdir might not be a child of _emacs_sitelispdir, yes?

Fixed by new commit, cruft line removed

churchyard commented 5 years ago

I wasn't sure those directories are bellow each other. In that case I guess I'd prefer:

%{_emacs_sitelispdir}/cython*
%{_emacs_sitestartdir}/cython*

Otherwise the package will own _emacs_sitestartdir.

Edited 5 years ago by churchyard

churchyard commented 5 years ago

See:

$ rpm -qpl emacs-cython-mode-0.29.1-2.fc30.noarch.rpm 
/usr/share/emacs/site-lisp/cython-mode.el
/usr/share/emacs/site-lisp/cython-mode.elc
/usr/share/emacs/site-lisp/site-start.d
/usr/share/emacs/site-lisp/site-start.d/cython-mode-init.el
/usr/share/emacs/site-lisp/site-start.d/cython-mode-init.elc
/usr/share/licenses/emacs-cython-mode
/usr/share/licenses/emacs-cython-mode/LICENSE.txt

The /usr/share/emacs/site-lisp/site-start.d directory should not be owned by emacs-cython-mode.

Edited 5 years ago by churchyard

acobb commented 5 years ago

I wasn't sure those directories are bellow each other. In that case I guess I'd prefer:
%{_emacs_sitelispdir}/cython
%{_emacs_sitestartdir}/cython

Otherwise the package will own _emacs_sitestartdir.

Oh, you are right.
%{_emacs_sitelispdir}/cython*.el*
%{_emacs_sitestartdir}/cython*.el*
?

1 new commit added

Fix files for emacs-cython-mode

5 years ago

churchyard commented 5 years ago

Looks good. I'll wait for https://koji.fedoraproject.org/koji/taskinfo?taskID=31890244 and check. if the result is alright, I'll squash + push + build.

churchyard commented 5 years ago

Thanks! Merged as https://src.fedoraproject.org/rpms/Cython/c/9c7f46b95bfd2acc7bd440a1f97d093332b37d38?branch=master