#1 Fix package requirements to use Python 3 packages
Closed 5 years ago by mreynolds. Opened 6 years ago by cheimes.
rpms/ cheimes/389-ds-base py3-packages  into  master

file modified
+7 -4
@@ -48,7 +48,7 @@ 

  Summary:          389 Directory Server (base)

  Name:             389-ds-base


- Release:          %{?relprefix}1%{?prerel}%{?dist}.2

+ Release:          %{?relprefix}1%{?prerel}%{?dist}.3

  License:          GPLv3+

  URL:              http://www.port389.org

  Group:            System Environment/Daemons
@@ -118,15 +118,15 @@ 



  # this is needed for using semanage from our setup scripts

- Requires:         policycoreutils-python-utils

+ Requires:         policycoreutils-python%{python3_pkgversion}-utils

  Requires:         /usr/sbin/semanage

- Requires:         libsemanage-python

+ Requires:         libsemanage-python%{python3_pkgversion}


  Requires:         selinux-policy >= 3.13.1-137


  # the following are needed for some of our scripts

  Requires:         openldap-clients

- Requires:         python-ldap

+ Requires:         python%{python3_pkgversion}-ldap

I don't think there is a "python3-ldap" package. I do see python3-ldap3, but I'm not sure that's what we want.


  # use_openldap assumes perl-Mozilla-LDAP is built with openldap support

  Requires:         perl-Mozilla-LDAP
@@ -596,6 +596,9 @@ 




+ * Wed Feb 14 2018 Christian Heimes <cheimes@redhat.com> -

+ - Fix package requirements to use Python 3 packages for LDAP and SELinux


  * Fri Feb 09 2018 Igor Gnatenko <ignatenkobrain@fedoraproject.org> -

  - Escape macros in %%changelog


All scripts are using /usr/bin/python3 but 389-ds-base was still
requiring Python 2 packages for LDAP and SELinux.

Signed-off-by: Christian Heimes cheimes@redhat.com

I don't think there is a "python3-ldap" package. I do see python3-ldap3, but I'm not sure that's what we want.

python3-ldap is the successor of python3-pyldap. pyldap was a fork of python-ldap for Python 3. Petr Viktorin took over python-ldap and we merged pyldap back into python-ldap.

Should the spec file work on F27, too? I can change the PR to check for Fedora version.

%if 0%{?fedora} >= 28
Requires:         python%{python3_pkgversion}-ldap
Requires:         python%{python3_pkgversion}-pyldap

We only need this change for F28. 389 in F27 is not ready for python3. So based on everyone's comments I have no objections to the proposed change. Thanks!

@mreynolds @cheimes If you agree, guys, I think we can close this PR as it is already fixed in F28 and master. Two of the PR-altered Requires: already explicitly mention the python3 packages' version and policycoreutils-python-utils explicitly depends on its python3 versioned sub-package.

@mhonek I agree, please close the PR. I don't have permission to close it.

@mreynolds Mark, please, could you close this? I have no rights either.

Pull-Request has been closed by mreynolds

5 years ago