sgallagh / rpms / rpm

Forked from rpms/rpm 4 years ago
Clone
5e19ecc
diff -up rpm-4.7.90.git9278/build/rpmfc.c.devel-autodep rpm-4.7.90.git9278/build/rpmfc.c
5e19ecc
--- rpm-4.7.90.git9278/build/rpmfc.c.devel-autodep	2009-09-01 10:45:07.000000000 +0300
5e19ecc
+++ rpm-4.7.90.git9278/build/rpmfc.c	2009-09-01 11:00:15.000000000 +0300
5e19ecc
@@ -501,7 +501,7 @@ static const struct rpmfcTokens_s const 
5e19ecc
   { "GLS_BINARY_LSB_FIRST",	RPMFC_WHITE|RPMFC_INCLUDE },
5e19ecc
   { " DB ",			RPMFC_WHITE|RPMFC_INCLUDE },
b60210f
 
b60210f
-  { "symbolic link to",		RPMFC_SYMLINK },
b60210f
+  { "symbolic link to",		RPMFC_SYMLINK|RPMFC_INCLUDE },
b60210f
   { "socket",			RPMFC_DEVICE },
b60210f
   { "special",			RPMFC_DEVICE },
5e19ecc
   { " text",			RPMFC_TEXT|RPMFC_INCLUDE },
5e19ecc
@@ -663,6 +663,105 @@ rpmds rpmfcRequires(rpmfc fc)
b60210f
 
b60210f
 
b60210f
 /**
b60210f
+ * Ensure that symlinks for shared libs generate a dep on the shared lib
b60210f
+ * @param fc            file classifier
b60210f
+ * @return              0 on success
b60210f
+ */
b60210f
+static int rpmfcSYMLINK(rpmfc fc)
b60210f
+{
b60210f
+    const char * fn = fc->fn[fc->ix];
b60210f
+    struct stat sb;
b60210f
+    int fdno;
b60210f
+
b60210f
+    if (fc->skipReq) 
b60210f
+	return 0;
b60210f
+
b60210f
+    if (stat(fn, &sb) < 0)
b60210f
+	return -1;
b60210f
+    if (S_ISLNK(sb.st_mode))
b60210f
+        return -1;
b60210f
+    
b60210f
+    fdno = open(fn, O_RDONLY);
b60210f
+    if (fdno < 0) {
b60210f
+	return fdno;
b60210f
+    }
b60210f
+
b60210f
+#if HAVE_GELF_H && HAVE_LIBELF
b60210f
+    Elf * elf = NULL;
b60210f
+    GElf_Ehdr ehdr_mem, * ehdr;
b60210f
+    int isElf64 = 0;
b60210f
+    int i, cnt;
b60210f
+    char * soname = NULL;
b60210f
+    rpmds ds;
b60210f
+
b60210f
+    (void) elf_version(EV_CURRENT);
b60210f
+    elf = NULL;
b60210f
+    if ((elf = elf_begin (fdno, ELF_C_READ_MMAP, NULL)) == NULL
b60210f
+        || elf_kind(elf) != ELF_K_ELF
b60210f
+        || (ehdr = gelf_getehdr(elf, &ehdr_mem)) == NULL
b60210f
+        || ehdr->e_type != ET_DYN)
b60210f
+	goto exit;
b60210f
+
b60210f
+/* alpha uses /lib, not /lib64 so don't add (64bit) deps */
b60210f
+#if !defined(__alpha__)
b60210f
+    isElf64 = ehdr->e_ident[EI_CLASS] == ELFCLASS64;
b60210f
+#endif
b60210f
+
b60210f
+    for (i = 0; i < ehdr->e_phnum; ++i) {
b60210f
+	GElf_Phdr phdr_mem;
b60210f
+	GElf_Phdr *phdr = gelf_getphdr (elf, i, &phdr_mem);
b60210f
+	GElf_Shdr shdr_mem;
b60210f
+	Elf_Data * data = NULL;
b60210f
+	Elf_Scn * scn;
b60210f
+	GElf_Shdr *shdr;
b60210f
+
b60210f
+	if (phdr == NULL || phdr->p_type != PT_DYNAMIC)
b60210f
+	    continue;
b60210f
+
b60210f
+	scn = gelf_offscn(elf, phdr->p_offset);
b60210f
+	shdr = gelf_getshdr(scn, &shdr_mem);
b60210f
+
b60210f
+	if (shdr != NULL && shdr->sh_type == SHT_DYNAMIC)
b60210f
+	    data = elf_getdata (scn, NULL);
b60210f
+	if (data == NULL)
b60210f
+	    continue; 
b60210f
+	  
b60210f
+	for (cnt = 0; cnt < shdr->sh_size / shdr->sh_entsize; ++cnt) {
b60210f
+	    GElf_Dyn dynmem;
b60210f
+	    GElf_Dyn *dyn = gelf_getdyn (data, cnt, &dynmem);
b60210f
+	    char *depname = NULL;
b60210f
+
b60210f
+	    if (dyn == NULL)
b60210f
+		break;
b60210f
+	    if (dyn->d_tag != DT_SONAME)
b60210f
+		continue;
b60210f
+
b60210f
+	    /* add the soname to package deps */
b60210f
+	    soname = elf_strptr(elf, shdr->sh_link, dyn->d_un.d_val);
b60210f
+	    if (soname == NULL)
b60210f
+		break;
b60210f
+
b60210f
+	    rasprintf(&depname, "%s%s", soname, isElf64 ? "()(64bit)" : "");
b60210f
+	    /* Add to package dependencies. */
b60210f
+	    ds = rpmdsSingle(RPMTAG_REQUIRENAME, depname, "", 
b60210f
+			     RPMSENSE_FIND_REQUIRES);
b60210f
+	    free(depname);
b60210f
+
b60210f
+	    rpmdsMerge(&fc->requires, ds);
b60210f
+	    rpmfcAddFileDep(&fc->ddict, fc->ix, ds);
b60210f
+	    ds = rpmdsFree(ds);
b60210f
+	    break;
b60210f
+	}
b60210f
+    }
b60210f
+exit:
b60210f
+    if (elf) (void) elf_end(elf);
b60210f
+    close(fdno);
b60210f
+    return 0;
b60210f
+#endif
b60210f
+    return -1;
b60210f
+}
b60210f
+
b60210f
+/**
b60210f
  * Extract script dependencies.
b60210f
  * @param fc		file classifier
b60210f
  * @return		0 on success
5e19ecc
@@ -1118,6 +1217,7 @@ static const struct rpmfcApplyTbl_s cons
5e19ecc
 			 RPMFC_PERL|RPMFC_PYTHON|RPMFC_MONO|RPMFC_OCAML|
b60210f
 			 RPMFC_PKGCONFIG|RPMFC_LIBTOOL) },
5e19ecc
     { rpmfcMISC,	RPMFC_FONT|RPMFC_TEXT },
b60210f
+    { rpmfcSYMLINK,	RPMFC_SYMLINK },
b60210f
     { NULL, 0 }
b60210f
 };
b60210f
 
5e19ecc
@@ -1138,6 +1238,7 @@ rpmRC rpmfcApply(rpmfc fc)
b60210f
     int ix;
b60210f
     int i;
b60210f
     int xx;
b60210f
+    int skipping = 0;
b60210f
 
b60210f
     /* Generate package and per-file dependencies. */
b60210f
     for (fc->ix = 0; fc->fn[fc->ix] != NULL; fc->ix++) {
5e19ecc
@@ -1192,11 +1293,13 @@ rpmRC rpmfcApply(rpmfc fc)
b60210f
 	default:
b60210f
 	    break;
b60210f
 	case 'P':	
b60210f
+	    skipping = fc->skipProv;
b60210f
 	    ds = rpmdsSingle(RPMTAG_PROVIDENAME, N, EVR, Flags);
b60210f
 	    dix = rpmdsFind(fc->provides, ds);
b60210f
 	    ds = rpmdsFree(ds);
b60210f
 	    break;
b60210f
 	case 'R':
b60210f
+	    skipping = fc->skipReq;
b60210f
 	    ds = rpmdsSingle(RPMTAG_REQUIRENAME, N, EVR, Flags);
b60210f
 	    dix = rpmdsFind(fc->requires, ds);
b60210f
 	    ds = rpmdsFree(ds);
5e19ecc
@@ -1218,7 +1321,7 @@ assert(dix >= 0);
b60210f
 	    previx = ix;
b60210f
 	    xx = argiAdd(&fc->fddictx, ix, argiCount(fc->ddictx)-1);
b60210f
 	}
b60210f
-	if (fc->fddictn && fc->fddictn->vals)
b60210f
+	if (fc->fddictn && fc->fddictn->vals && !skipping)
b60210f
 	    fc->fddictn->vals[ix]++;
b60210f
     }
b60210f