|
 |
3a13ddd |
From: Prasad J Pandit <pjp@fedoraproject.org>
|
|
|
3a13ddd |
Date: Wed, 31 Aug 2016 12:19:29 +0530
|
|
|
3a13ddd |
Subject: [PATCH] vmw_pvscsi: check page count while initialising descriptor
|
|
|
3a13ddd |
rings
|
|
|
3a13ddd |
|
|
|
3a13ddd |
Vmware Paravirtual SCSI emulation uses command descriptors to
|
|
|
3a13ddd |
process SCSI commands. These descriptors come with their ring
|
|
|
3a13ddd |
buffers. A guest could set the page count for these rings to
|
|
|
3a13ddd |
an arbitrary value, leading to infinite loop or OOB access.
|
|
|
3a13ddd |
Add check to avoid it.
|
|
|
3a13ddd |
|
|
|
3a13ddd |
Reported-by: Tom Victor <vv474172261@gmail.com>
|
|
|
3a13ddd |
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
|
|
|
3a13ddd |
Message-Id: <1472626169-12989-1-git-send-email-ppandit@redhat.com>
|
|
|
3a13ddd |
Cc: qemu-stable@nongnu.org
|
|
|
3a13ddd |
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
3a13ddd |
(cherry picked from commit 7f61f4690dd153be98900a2a508b88989e692753)
|
|
|
3a13ddd |
---
|
|
|
3a13ddd |
hw/scsi/vmw_pvscsi.c | 19 +++++++++----------
|
|
|
3a13ddd |
1 file changed, 9 insertions(+), 10 deletions(-)
|
|
|
3a13ddd |
|
|
|
3a13ddd |
diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c
|
|
|
3a13ddd |
index 5116f4a..4245c15 100644
|
|
|
3a13ddd |
--- a/hw/scsi/vmw_pvscsi.c
|
|
|
3a13ddd |
+++ b/hw/scsi/vmw_pvscsi.c
|
|
|
3a13ddd |
@@ -152,7 +152,7 @@ pvscsi_log2(uint32_t input)
|
|
|
3a13ddd |
return log;
|
|
|
3a13ddd |
}
|
|
|
3a13ddd |
|
|
|
3a13ddd |
-static int
|
|
|
3a13ddd |
+static void
|
|
|
3a13ddd |
pvscsi_ring_init_data(PVSCSIRingInfo *m, PVSCSICmdDescSetupRings *ri)
|
|
|
3a13ddd |
{
|
|
|
3a13ddd |
int i;
|
|
|
3a13ddd |
@@ -160,10 +160,6 @@ pvscsi_ring_init_data(PVSCSIRingInfo *m, PVSCSICmdDescSetupRings *ri)
|
|
|
3a13ddd |
uint32_t req_ring_size, cmp_ring_size;
|
|
|
3a13ddd |
m->rs_pa = ri->ringsStatePPN << VMW_PAGE_SHIFT;
|
|
|
3a13ddd |
|
|
|
3a13ddd |
- if ((ri->reqRingNumPages > PVSCSI_SETUP_RINGS_MAX_NUM_PAGES)
|
|
|
3a13ddd |
- || (ri->cmpRingNumPages > PVSCSI_SETUP_RINGS_MAX_NUM_PAGES)) {
|
|
|
3a13ddd |
- return -1;
|
|
|
3a13ddd |
- }
|
|
|
3a13ddd |
req_ring_size = ri->reqRingNumPages * PVSCSI_MAX_NUM_REQ_ENTRIES_PER_PAGE;
|
|
|
3a13ddd |
cmp_ring_size = ri->cmpRingNumPages * PVSCSI_MAX_NUM_CMP_ENTRIES_PER_PAGE;
|
|
|
3a13ddd |
txr_len_log2 = pvscsi_log2(req_ring_size - 1);
|
|
|
3a13ddd |
@@ -195,8 +191,6 @@ pvscsi_ring_init_data(PVSCSIRingInfo *m, PVSCSICmdDescSetupRings *ri)
|
|
|
3a13ddd |
|
|
|
3a13ddd |
/* Flush ring state page changes */
|
|
|
3a13ddd |
smp_wmb();
|
|
|
3a13ddd |
-
|
|
|
3a13ddd |
- return 0;
|
|
|
3a13ddd |
}
|
|
|
3a13ddd |
|
|
|
3a13ddd |
static int
|
|
|
3a13ddd |
@@ -746,7 +740,7 @@ pvscsi_dbg_dump_tx_rings_config(PVSCSICmdDescSetupRings *rc)
|
|
|
3a13ddd |
|
|
|
3a13ddd |
trace_pvscsi_tx_rings_num_pages("Confirm Ring", rc->cmpRingNumPages);
|
|
|
3a13ddd |
for (i = 0; i < rc->cmpRingNumPages; i++) {
|
|
|
3a13ddd |
- trace_pvscsi_tx_rings_ppn("Confirm Ring", rc->reqRingPPNs[i]);
|
|
|
3a13ddd |
+ trace_pvscsi_tx_rings_ppn("Confirm Ring", rc->cmpRingPPNs[i]);
|
|
|
3a13ddd |
}
|
|
|
3a13ddd |
}
|
|
|
3a13ddd |
|
|
|
3a13ddd |
@@ -779,11 +773,16 @@ pvscsi_on_cmd_setup_rings(PVSCSIState *s)
|
|
|
3a13ddd |
|
|
|
3a13ddd |
trace_pvscsi_on_cmd_arrived("PVSCSI_CMD_SETUP_RINGS");
|
|
|
3a13ddd |
|
|
|
3a13ddd |
- pvscsi_dbg_dump_tx_rings_config(rc);
|
|
|
3a13ddd |
- if (pvscsi_ring_init_data(&s->rings, rc) < 0) {
|
|
|
3a13ddd |
+ if (!rc->reqRingNumPages
|
|
|
3a13ddd |
+ || rc->reqRingNumPages > PVSCSI_SETUP_RINGS_MAX_NUM_PAGES
|
|
|
3a13ddd |
+ || !rc->cmpRingNumPages
|
|
|
3a13ddd |
+ || rc->cmpRingNumPages > PVSCSI_SETUP_RINGS_MAX_NUM_PAGES) {
|
|
|
3a13ddd |
return PVSCSI_COMMAND_PROCESSING_FAILED;
|
|
|
3a13ddd |
}
|
|
|
3a13ddd |
|
|
|
3a13ddd |
+ pvscsi_dbg_dump_tx_rings_config(rc);
|
|
|
3a13ddd |
+ pvscsi_ring_init_data(&s->rings, rc);
|
|
|
3a13ddd |
+
|
|
|
3a13ddd |
s->rings_info_valid = TRUE;
|
|
|
3a13ddd |
return PVSCSI_COMMAND_PROCESSING_SUCCEEDED;
|
|
|
3a13ddd |
}
|