|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
From a2426829ce426de82d2fa47071ca41ea81c43307 Mon Sep 17 00:00:00 2001
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
Message-Id: <a2426829ce426de82d2fa47071ca41ea81c43307.1527581614.git.davide.caratti@gmail.com>
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
From: Jouni Malinen <jouni@qca.qualcomm.com>
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
Date: Fri, 1 Dec 2017 20:22:44 +0200
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
Subject: [PATCH] nl80211: Fix NL80211_ATTR_SMPS_MODE encoding
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
This nl80211 attribute uses NLA_U8 policy in cfg80211 and
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
hostapd/wpa_supplicant needs to use same size when writing the
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
attribute.
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
This fixes AP mode regression triggered by kernel commit "net: netlink:
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
Update attr validation to require exact length for some types" in
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
v4.15-rc1 that resulted in the following debug log entry when trying to
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
enable beaconing:
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
nl80211: Beacon set failed: -34 (Numerical result out of range)
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
Fixes: da1080d7215f ("nl80211: Advertise and configure SMPS modes")
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
---
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
src/drivers/driver_nl80211.c | 2 +-
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
index 2ce03ed76..7571e77f0 100644
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
--- a/src/drivers/driver_nl80211.c
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
+++ b/src/drivers/driver_nl80211.c
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
@@ -3957,7 +3957,7 @@ static int wpa_driver_nl80211_set_ap(void *priv,
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
smps_mode = NL80211_SMPS_OFF;
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
break;
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
}
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
- if (nla_put_u32(msg, NL80211_ATTR_SMPS_MODE, smps_mode))
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
+ if (nla_put_u8(msg, NL80211_ATTR_SMPS_MODE, smps_mode))
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
goto fail;
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
}
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
--
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
2.17.0
|
|
![](https://seccdn.libravatar.org/avatar/9c80e75af4e6e1de662a4c2316afef74a76712084faadbeafbce9ee4b039d721?s=16&d=retro) |
b44ff58 |
|