|
 |
12b8d0b |
# HG changeset patch
|
|
|
12b8d0b |
# User Lars T Hansen <lhansen@mozilla.com>
|
|
|
12b8d0b |
# Date 1519822672 -3600
|
|
|
12b8d0b |
# Wed Feb 28 13:57:52 2018 +0100
|
|
|
12b8d0b |
# Node ID 672f0415217b202ae59a930769dffd9d6ba6b87c
|
|
|
12b8d0b |
# Parent 825fd04dacc6297d3a980ec4184079405950b35d
|
|
|
12b8d0b |
Bug 1375074 - Save and restore non-volatile x28 on ARM64 for generated unboxed object constructor.
|
|
|
12b8d0b |
|
|
|
12b8d0b |
diff --git a/js/src/jit-test/tests/bug1375074.js b/js/src/jit-test/tests/bug1375074.js
|
|
|
12b8d0b |
new file mode 100644
|
|
|
12b8d0b |
--- /dev/null
|
|
|
12b8d0b |
+++ b/js/src/jit-test/tests/bug1375074.js
|
|
|
12b8d0b |
@@ -0,0 +1,18 @@
|
|
|
12b8d0b |
+// This forces the VM to start creating unboxed objects and thus stresses a
|
|
|
12b8d0b |
+// particular path into generated code for a specialized unboxed object
|
|
|
12b8d0b |
+// constructor.
|
|
|
12b8d0b |
+
|
|
|
12b8d0b |
+var K = 2000; // 2000 should be plenty
|
|
|
12b8d0b |
+var s = "[";
|
|
|
12b8d0b |
+var i;
|
|
|
12b8d0b |
+for ( i=0; i < K-1; i++ )
|
|
|
12b8d0b |
+ s = s + `{"i":${i}},`;
|
|
|
12b8d0b |
+s += `{"i":${i}}]`;
|
|
|
12b8d0b |
+var v = JSON.parse(s);
|
|
|
12b8d0b |
+
|
|
|
12b8d0b |
+assertEq(v.length == K, true);
|
|
|
12b8d0b |
+
|
|
|
12b8d0b |
+for ( i=0; i < K; i++) {
|
|
|
12b8d0b |
+ assertEq(v[i] instanceof Object, true);
|
|
|
12b8d0b |
+ assertEq(v[i].i, i);
|
|
|
12b8d0b |
+}
|
|
|
12b8d0b |
diff --git a/js/src/vm/UnboxedObject.cpp b/js/src/vm/UnboxedObject.cpp
|
|
|
12b8d0b |
--- a/js/src/vm/UnboxedObject.cpp
|
|
|
12b8d0b |
+++ b/js/src/vm/UnboxedObject.cpp
|
|
|
12b8d0b |
@@ -95,7 +95,15 @@ UnboxedLayout::makeConstructorCode(JSCon
|
|
|
12b8d0b |
#endif
|
|
|
12b8d0b |
|
|
|
12b8d0b |
#ifdef JS_CODEGEN_ARM64
|
|
|
12b8d0b |
- // ARM64 communicates stack address via sp, but uses a pseudo-sp for addressing.
|
|
|
12b8d0b |
+ // ARM64 communicates stack address via sp, but uses a pseudo-sp (PSP) for
|
|
|
12b8d0b |
+ // addressing. The register we use for PSP may however also be used by
|
|
|
12b8d0b |
+ // calling code, and it is nonvolatile, so save it. Do this as a special
|
|
|
12b8d0b |
+ // case first because the generic save/restore code needs the PSP to be
|
|
|
12b8d0b |
+ // initialized already.
|
|
|
12b8d0b |
+ MOZ_ASSERT(PseudoStackPointer64.Is(masm.GetStackPointer64()));
|
|
|
12b8d0b |
+ masm.Str(PseudoStackPointer64, vixl::MemOperand(sp, -16, vixl::PreIndex));
|
|
|
12b8d0b |
+
|
|
|
12b8d0b |
+ // Initialize the PSP from the SP.
|
|
|
12b8d0b |
masm.initStackPtr();
|
|
|
12b8d0b |
#endif
|
|
|
12b8d0b |
|
|
|
12b8d0b |
@@ -233,7 +241,22 @@ UnboxedLayout::makeConstructorCode(JSCon
|
|
|
12b8d0b |
masm.pop(ScratchDoubleReg);
|
|
|
12b8d0b |
masm.PopRegsInMask(savedNonVolatileRegisters);
|
|
|
12b8d0b |
|
|
|
12b8d0b |
+#ifdef JS_CODEGEN_ARM64
|
|
|
12b8d0b |
+ // Now restore the value that was in the PSP register on entry, and return.
|
|
|
12b8d0b |
+
|
|
|
12b8d0b |
+ // Obtain the correct SP from the PSP.
|
|
|
12b8d0b |
+ masm.Mov(sp, PseudoStackPointer64);
|
|
|
12b8d0b |
+
|
|
|
12b8d0b |
+ // Restore the saved value of the PSP register, this value is whatever the
|
|
|
12b8d0b |
+ // caller had saved in it, not any actual SP value, and it must not be
|
|
|
12b8d0b |
+ // overwritten subsequently.
|
|
|
12b8d0b |
+ masm.Ldr(PseudoStackPointer64, vixl::MemOperand(sp, 16, vixl::PostIndex));
|
|
|
12b8d0b |
+
|
|
|
12b8d0b |
+ // Perform a plain Ret(), as abiret() will move SP <- PSP and that is wrong.
|
|
|
12b8d0b |
+ masm.Ret(vixl::lr);
|
|
|
12b8d0b |
+#else
|
|
|
12b8d0b |
masm.abiret();
|
|
|
12b8d0b |
+#endif
|
|
|
12b8d0b |
|
|
|
12b8d0b |
masm.bind(&failureStoreOther);
|
|
|
12b8d0b |
|