Blame pr3479-rh1486025-sunec_provider_can_have_multiple_instances_leading_to_premature_nss_shutdown.patch

2437fa0
# HG changeset patch
2437fa0
# User andrew
2437fa0
# Date 1508194072 -3600
2437fa0
#      Mon Oct 16 23:47:52 2017 +0100
2437fa0
# Node ID 5dcb55da00c1531264934559c9f10c2e0ae46420
2437fa0
# Parent  bf62c56e3604fee0018b19f65fd56c76dc156630
2437fa0
PR3479, RH1486025: ECC and NSS JVM crash
2437fa0
Summary: SunEC provider can have multiple instances, leading to premature NSS shutdown
2437fa0
Contributed-by: Martin Balao <mbalao@redhat.com>
2437fa0
2437fa0
diff --git a/make/mapfiles/libsunec/mapfile-vers b/make/mapfiles/libsunec/mapfile-vers
2437fa0
--- openjdk/jdk/make/mapfiles/libsunec/mapfile-vers
2437fa0
+++ openjdk/jdk/make/mapfiles/libsunec/mapfile-vers
2437fa0
@@ -32,7 +32,6 @@
2437fa0
                 Java_sun_security_ec_ECDSASignature_verifySignedDigest;
2437fa0
                 Java_sun_security_ec_ECDHKeyAgreement_deriveKey;
2437fa0
 		Java_sun_security_ec_SunEC_initialize;
2437fa0
-		Java_sun_security_ec_SunEC_cleanup;
2437fa0
         local:
2437fa0
                 *;
2437fa0
 };
2437fa0
diff --git a/src/share/classes/sun/security/ec/SunEC.java b/src/share/classes/sun/security/ec/SunEC.java
2437fa0
--- openjdk/jdk/src/share/classes/sun/security/ec/SunEC.java
2437fa0
+++ openjdk/jdk/src/share/classes/sun/security/ec/SunEC.java
2437fa0
@@ -83,21 +83,8 @@
2437fa0
     }
2437fa0
 
2437fa0
     /**
2437fa0
-     * Cleanup native resources during finalisation.
2437fa0
-     */
2437fa0
-    @Override
2437fa0
-    protected void finalize() {
2437fa0
-        cleanup();
2437fa0
-    }
2437fa0
-
2437fa0
-    /**
2437fa0
      * Initialize the native code.
2437fa0
      */
2437fa0
     private static native void initialize();
2437fa0
 
2437fa0
-    /**
2437fa0
-     * Cleanup in the native layer.
2437fa0
-     */
2437fa0
-    private static native void cleanup();
2437fa0
-
2437fa0
 }
2437fa0
diff --git a/src/share/native/sun/security/ec/ECC_JNI.cpp b/src/share/native/sun/security/ec/ECC_JNI.cpp
2437fa0
--- openjdk/jdk/src/share/native/sun/security/ec/ECC_JNI.cpp
2437fa0
+++ openjdk/jdk/src/share/native/sun/security/ec/ECC_JNI.cpp
2437fa0
@@ -525,14 +525,12 @@
2437fa0
 }
2437fa0
 
2437fa0
 JNIEXPORT void
2437fa0
-JNICALL Java_sun_security_ec_SunEC_cleanup
2437fa0
-  (JNIEnv *env, jclass UNUSED(clazz))
2437fa0
+JNICALL JNI_OnUnload
2437fa0
+  (JavaVM *vm, void *reserved)
2437fa0
 {
2437fa0
 #ifdef SYSTEM_NSS
2437fa0
     RNG_RNGShutdown();
2437fa0
-    if (SECOID_Shutdown() != SECSuccess) {
2437fa0
-	ThrowException(env, INTERNAL_ERROR);
2437fa0
-    }
2437fa0
+    SECOID_Shutdown();
2437fa0
 #endif
2437fa0
 }
2437fa0