ishcherb / rpms / abrt

Forked from rpms/abrt 6 years ago
Clone

Blame 0020-a-h-event-don-t-spam-system-logs.patch

Jakub Filak 6313c5e
From 88cd0ba3d8bcbe597d777895952a3867fd789f12 Mon Sep 17 00:00:00 2001
Jakub Filak 6313c5e
From: Jakub Filak <jfilak@redhat.com>
Jakub Filak 6313c5e
Date: Tue, 26 Aug 2014 23:57:46 +0200
Jakub Filak 6313c5e
Subject: [PATCH 20/24] a-h-event: don't spam system logs
Jakub Filak 6313c5e
Jakub Filak 6313c5e
Don't print messages about invalid dump directories so many times.
Jakub Filak 6313c5e
Every dump directory has at leas 4 post-create events and after end of
Jakub Filak 6313c5e
each of these events abrt-handle-event tries to find duplicates. It
Jakub Filak 6313c5e
means 4x opens every dump directory, so it prints 4 lines for a single
Jakub Filak 6313c5e
invalid dump directory.
Jakub Filak 6313c5e
Jakub Filak 6313c5e
This patch dissables the error messages in the default log mode.
Jakub Filak 6313c5e
Jakub Filak 6313c5e
Related to rhbz#1133674
Jakub Filak 6313c5e
Jakub Filak 6313c5e
Signed-off-by: Jakub Filak <jfilak@redhat.com>
Jakub Filak 6313c5e
---
Jakub Filak 6313c5e
 src/daemon/abrt-handle-event.c | 4 ++++
Jakub Filak 6313c5e
 1 file changed, 4 insertions(+)
Jakub Filak 6313c5e
Jakub Filak 6313c5e
diff --git a/src/daemon/abrt-handle-event.c b/src/daemon/abrt-handle-event.c
Jakub Filak 6313c5e
index 7100171..a65f86e 100644
Jakub Filak 6313c5e
--- a/src/daemon/abrt-handle-event.c
Jakub Filak 6313c5e
+++ b/src/daemon/abrt-handle-event.c
Jakub Filak 6313c5e
@@ -282,7 +282,11 @@ static int is_crash_a_dup(const char *dump_dir_name, void *param)
Jakub Filak 6313c5e
         if (strcmp(dump_dir_name, dump_dir_name2) == 0)
Jakub Filak 6313c5e
             goto next; /* we are never a dup of ourself */
Jakub Filak 6313c5e
 
Jakub Filak 6313c5e
+        int sv_logmode = logmode;
Jakub Filak 6313c5e
+        /* Silently ignore any error in the silent log level. */
Jakub Filak 6313c5e
+        logmode = g_verbose == 0 ? 0 : sv_logmode;
Jakub Filak 6313c5e
         dd = dd_opendir(dump_dir_name2, /*flags:*/ DD_FAIL_QUIETLY_ENOENT | DD_OPEN_READONLY);
Jakub Filak 6313c5e
+        logmode = sv_logmode;
Jakub Filak 6313c5e
         if (!dd)
Jakub Filak 6313c5e
             goto next;
Jakub Filak 6313c5e
 
Jakub Filak 6313c5e
-- 
Jakub Filak 6313c5e
2.1.0
Jakub Filak 6313c5e