Debarshi Ray 9c93d53
From 9d8b070982403ff8e608d4c7cce313bc2a7dce4a Mon Sep 17 00:00:00 2001
Debarshi Ray 9c93d53
From: Debarshi Ray <debarshir@gnome.org>
Debarshi Ray 9c93d53
Date: Thu, 19 Sep 2019 13:54:53 +0200
Debarshi Ray 9c93d53
Subject: [PATCH] util: Blacklist NOTIFY_SOCKET
Debarshi Ray 9c93d53
Debarshi Ray 9c93d53
The NOTIFY_SOCKET environment variable was leaking into systemd
Debarshi Ray 9c93d53
managed GNOME sessions and breaking things like OCI container runtimes
Debarshi Ray 9c93d53
(eg., runc and crun) [1]. This variable is absent in non-systemd
Debarshi Ray 9c93d53
managed sessions.
Debarshi Ray 9c93d53
Debarshi Ray 9c93d53
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1753328
Debarshi Ray 9c93d53
Debarshi Ray 9c93d53
https://gitlab.gnome.org/GNOME/gnome-session/merge_requests/22
Debarshi Ray 9c93d53
---
Debarshi Ray 9c93d53
 gnome-session/gsm-util.c | 1 +
Debarshi Ray 9c93d53
 1 file changed, 1 insertion(+)
Debarshi Ray 9c93d53
Debarshi Ray 9c93d53
diff --git a/gnome-session/gsm-util.c b/gnome-session/gsm-util.c
Debarshi Ray 9c93d53
index f6ddefc374dc..1528723cc7d8 100644
Debarshi Ray 9c93d53
--- a/gnome-session/gsm-util.c
Debarshi Ray 9c93d53
+++ b/gnome-session/gsm-util.c
Debarshi Ray 9c93d53
@@ -36,6 +36,7 @@ static gchar *_saved_session_dir = NULL;
Debarshi Ray 9c93d53
 static gchar **child_environment;
Debarshi Ray 9c93d53
 
Debarshi Ray 9c93d53
 static const char * const variable_blacklist[] = {
Debarshi Ray 9c93d53
+    "NOTIFY_SOCKET",
Debarshi Ray 9c93d53
     "XDG_SEAT",
Debarshi Ray 9c93d53
     "XDG_SESSION_ID",
Debarshi Ray 9c93d53
     "XDG_VTNR",
Debarshi Ray 9c93d53
-- 
Debarshi Ray 9c93d53
2.20.1
Debarshi Ray 9c93d53