Blame glibc-rh1321861.patch
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
commit a6033052d08027f745867e5e346852da1959226c
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
Author: Florian Weimer <fweimer@redhat.com>
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
Date: Tue Mar 29 11:27:32 2016 +0200
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
nss_db: Propagate ERANGE error if parse_line fails [BZ #19837]
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
Reproducer (needs to run as root):
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
perl -e \
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
'print "large:x:999:" . join(",", map {"user$_"} (1 .. 135))."\n"' \
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
>> /etc/group
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
cd /var/db
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
make
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
getent -s db group
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
After the fix, the last command should list the "large" group.
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
The magic number 135 has been chosen so that the line is shorter than
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
1024 bytes, but the pointers required to encode the member array will
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
cross the threshold, triggering the bug.
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
diff --git a/nss/nss_db/db-XXX.c b/nss/nss_db/db-XXX.c
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
index 03c18d7..125a5e9 100644
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
--- a/nss/nss_db/db-XXX.c
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
+++ b/nss/nss_db/db-XXX.c
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
@@ -288,8 +288,8 @@ CONCAT(_nss_db_get,ENTNAME_r) (struct STRUCTURE *result, char *buffer,
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
}
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
if (err < 0)
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
{
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
- H_ERRNO_SET (HOST_NOT_FOUND);
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
- status = NSS_STATUS_NOTFOUND;
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
+ H_ERRNO_SET (NETDB_INTERNAL);
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
+ status = NSS_STATUS_TRYAGAIN;
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
break;
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
}
|
|
![](https://seccdn.libravatar.org/avatar/3a472f8ae167e3d9ad669220b1e8ed6d98f2576fa0461d58f9444841c8e3b2f5?s=16&d=retro) |
84517e1 |
|