|
 |
ba174f1 |
From e938d22e2131972a6e9eaddbf850c6a04a4f750c Mon Sep 17 00:00:00 2001
|
|
|
ba174f1 |
From: Jim Meyering <meyering@fb.com>
|
|
|
ba174f1 |
Date: Wed, 4 Nov 2015 10:57:07 -0800
|
|
|
ba174f1 |
Subject: [PATCH] tests: mark performance-related tests as expensive
|
|
|
ba174f1 |
|
|
|
ba174f1 |
These performance-related tests are slightly failure prone due to
|
|
|
ba174f1 |
varying system load during the two runs.
|
|
|
ba174f1 |
Marking these tests as "expensive" makes it so they are no longer run
|
|
|
ba174f1 |
via "make check". You can still run them via make "check-expensive".
|
|
|
ba174f1 |
This makes them less likely to be run by regular users.
|
|
|
ba174f1 |
* tests/long-pattern-perf: Use expensive_.
|
|
|
ba174f1 |
* tests/mb-non-UTF8-performance: Likewise.
|
|
|
ba174f1 |
Reported by Jaroslav Skarvada in http://debbugs.gnu.org/21826
|
|
|
ba174f1 |
and by Andreas Schwab in http://debbugs.gnu.org/21812.
|
|
|
ba174f1 |
---
|
|
|
ba174f1 |
tests/long-pattern-perf | 5 +++++
|
|
|
ba174f1 |
tests/mb-non-UTF8-performance | 5 +++++
|
|
|
ba174f1 |
2 files changed, 10 insertions(+)
|
|
|
ba174f1 |
|
|
|
ba174f1 |
diff --git a/tests/long-pattern-perf b/tests/long-pattern-perf
|
|
|
ba174f1 |
index c222c02..2c9d080 100755
|
|
|
ba174f1 |
--- a/tests/long-pattern-perf
|
|
|
ba174f1 |
+++ b/tests/long-pattern-perf
|
|
|
ba174f1 |
@@ -20,6 +20,11 @@
|
|
|
ba174f1 |
|
|
|
ba174f1 |
fail=0
|
|
|
ba174f1 |
|
|
|
ba174f1 |
+# This test is susceptible to failure due to differences in
|
|
|
ba174f1 |
+# system load during the two test runs, so we'll mark it as
|
|
|
ba174f1 |
+# "expensive", making it less likely to be run by regular users.
|
|
|
ba174f1 |
+expensive_
|
|
|
ba174f1 |
+
|
|
|
ba174f1 |
echo x > in || framework_failure_
|
|
|
ba174f1 |
# We could use seq -s '' (avoiding the tr filter), but I
|
|
|
ba174f1 |
# suspect some version of seq does not honor that option.
|
|
|
ba174f1 |
diff --git a/tests/mb-non-UTF8-performance b/tests/mb-non-UTF8-performance
|
|
|
ba174f1 |
index 228361d..9bd5d39 100755
|
|
|
ba174f1 |
--- a/tests/mb-non-UTF8-performance
|
|
|
ba174f1 |
+++ b/tests/mb-non-UTF8-performance
|
|
|
ba174f1 |
@@ -22,6 +22,11 @@
|
|
|
ba174f1 |
|
|
|
ba174f1 |
fail=0
|
|
|
ba174f1 |
|
|
|
ba174f1 |
+# This test is susceptible to failure due to differences in
|
|
|
ba174f1 |
+# system load during the two test runs, so we'll mark it as
|
|
|
ba174f1 |
+# "expensive", making it less likely to be run by regular users.
|
|
|
ba174f1 |
+expensive_
|
|
|
ba174f1 |
+
|
|
|
ba174f1 |
# Make this large enough so that even on high-end systems
|
|
|
ba174f1 |
# it incurs at least 5-10ms of user time.
|
|
|
ba174f1 |
yes $(printf '%078d' 0) | head -400000 > in || framework_failure_
|
|
|
ba174f1 |
--
|
|
|
ba174f1 |
2.6.0
|
|
|
ba174f1 |
|